[FIRRTL] Add inline convention to layers #6980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an "inline" convention to layers by adding this to the existing enumeration. By the nature of how the parser works, this automatically adds support to parse this attribute without modifications to the parser. This does not add any support for this in the FIRRTL pipeline. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
|
Super neat all it took was just extending the enum!!! Consider checking this emitter-side but looks like that just works similarly (untested)! So up to you. |
dtzSiFive
approved these changes
May 2, 2024
Yes, the emitter happily works, too. I modified an emitter test to check this here: 5063cc0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an "inline" convention to layers by adding this to the existing enumeration. By the nature of how the parser works, this automatically adds support to parse this attribute without modifications to the parser.
This does not add any support for this in the FIRRTL pipeline.