[SV] Add sv.func, sv.return and sv.func.call operations #7003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
approved these changes
May 9, 2024
| FunctionOpInterface, HasParent<"mlir::ModuleOp">]> { | ||
| let summary = "A System Verilog function"; | ||
| let description = [{ | ||
| `sv.func` reresents System Verilog function in SV spec 13.4. |
There was a problem hiding this comment.
Suggested change
| `sv.func` reresents System Verilog function in SV spec 13.4. | |
| `sv.func` reresents SystemVerilog function in SV spec 13.4. |
Can you also mention which exact version of the spec this is? They tend to insert paragraphs, which makes the numbering unstable. Something like see IEEE 1800-2017 section 13.4 "section title" maybe?
There was a problem hiding this comment.
Added! Thank you for great suggestion!
Comment on lines
+2406
to
+2414
| // Non-procedural call cannot have output arguments. | ||
| if (referencedOp.getNumOutputs() != 1 || | ||
| !referencedOp.getExplicitlyReturnedType()) { | ||
| auto diag = emitError() | ||
| << "function called in a non-procedural region must " | ||
| "return a single result"; | ||
| diag.attachNote(referencedOp.getLoc()) << "doesn't satisfy the constraint"; | ||
| return failure(); | ||
| } |
|
I'm going to merge the PR. Post-merge review is welcomed. The current implementation around a return value is slightly hacky especially the use of "sv.func.explicitly_returned". Probably a better way would be to introduce HWFunctionType with an explicit return type but I'll consider it as a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (separated from #6977) adds function call constructs (sv.func, sv.return and sv.func.call) to SV dialect.
sv.func-- this op is between hw.module and func.func. This op implement interfacesPortList,HWModuleLikeandFunctionOpInterface. Similar to hw.module, we can preserve argument names and mix the order of input and output arguments. Following func.func empty body indicates that the op is a declaration. Currently sv/func is defined as "automatic" function in SV.sv.return-- terminator for sv.func. We cannot reuse neither hw.output nor func.func since they have constraints on parent op(and I think it's not reasonable to loose them).sv.func.callandsv.func.call.procedural. Two operations are added because output arguments cannot be used non-procedural regions.