Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Don't prefix an empty label for unclocked assume. #7016

Merged
merged 1 commit into from
May 9, 2024
Merged

[FIRRTL] Don't prefix an empty label for unclocked assume. #7016

merged 1 commit into from
May 9, 2024

Conversation

dtzSiFive
Copy link
Contributor

Add FIR -> SV test for "unclocked_assert" since we care about ensuring it has a specific shape re:output.

Test extracted from #7010.

@dtzSiFive
[FIRRTL] Don't prefix an empty label for unclocked assume.
3f016f2 
Add FIR -> SV test for "unclocked_assert" since we care about ensuring
it has a specific shape re:output.

Test extracted from llvm#7010.
uenoku
uenoku approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtzSiFive dtzSiFive merged commit 0861eef into llvm:main May 9, 2024
4 checks passed
@dtzSiFive dtzSiFive deleted the fix/no-assume__-label branch May 9, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uenoku uenoku uenoku approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzSiFive @uenoku