Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Arc] Modify VectorizeOp to support AnyType #7087

Merged
merged 1 commit into from
May 25, 2024
Merged

[Arc] Modify VectorizeOp to support AnyType #7087

merged 1 commit into from
May 25, 2024

Conversation

elhewaty
Copy link
Member

No description provided.

fabianschuiki
fabianschuiki approved these changes May 25, 2024
View reviewed changes
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Since we are planning to use arc.vectorize fairly early in the pipeline to mark vectorizable regions of the design, it makes sense to allow for non-integer types such as !seq.clock, !hw.array, !hw.struct, as in this PR. 👍

@fabianschuiki fabianschuiki merged commit 021c3c2 into llvm:main May 25, 2024
4 checks passed
@elhewaty elhewaty deleted the vectorize-op-update branch May 25, 2024 19:17
jiahanxie353 pushed a commit to jiahanxie353/circt that referenced this pull request May 27, 2024
@elhewaty @jiahanxie353
[Arc] Modify VectorizeOp to support AnyType (llvm#7087)
02a3d74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianschuiki fabianschuiki fabianschuiki approved these changes

@maerhart maerhart Awaiting requested review from maerhart maerhart is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elhewaty @fabianschuiki