-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Expand the Nightly CI build coverage. #712
Conversation
Another dimension we may want to add is non-capnp vs capnp builds. We've had problems with one broken but not the other. I don't think it's necessary to run non-capnp vs capnp with all the other combinations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice. Thanks!
Can you split the LLVM compile and cache into a separate job which all the other jobs depend on? It'll prevent waste when we bump the LLVM version. I think caches are not shared between workflows, so this pipeline will not pick up the cached version from the CI check. |
1b66de3
to
dbf2772
Compare
I added a parent job to cache LLVM, test run here: https://github.com/llvm/circt/actions/runs/622293286 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
This PR expands the nightly builds to run more of our supported build configurations. This adds (almost) all combinations of the following variables: ``` CXX = [clang++, g++] BUILD_SHARED_LIBS = [ON, OFF] LLVM_ENABLE_ASSERTION = [ON, OFF] CMAKE_BUILD_TYPE = [Release, Debug] ``` The gcc+sharedlibs combinations have been disabled (see issue llvm#708). This leads to a total of 12 builds. Every build shares the same cached version of LLVM and should only take a couple of minutes for each to complete.
dbf2772
to
c3d5acd
Compare
Newest test run here: https://github.com/llvm/circt/actions/runs/622377130 |
This PR expands the nightly builds to run more of our supported build
configurations. This adds (almost) all combinations of the following
variables:
The gcc+sharedlibs combinations have been disabled (see issue #708).
This leads to a total of 12 builds. Every build shares the same cached
version of LLVM and should only take a couple of minutes for each to
complete.
Example build here: https://github.com/youngar/circt/actions/runs/617133108
Looks like its ~5 minutes per build, assuming LLVM is cached.