Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM IR dialect already supports zeroinitializer, get rid of ZeroInitConstOp #627

Closed
bcardosolopes opened this issue May 24, 2024 · 2 comments · Fixed by #646
Closed

LLVM IR dialect already supports zeroinitializer, get rid of ZeroInitConstOp #627

bcardosolopes opened this issue May 24, 2024 · 2 comments · Fixed by #646
Assignees
Labels
good first issue Good for newcomers

Comments

@bcardosolopes
Copy link
Member

Originally posted by @bcardosolopes in #617 (review)

@bcardosolopes
Copy link
Member Author

cc @ivanmurashko

@bcardosolopes bcardosolopes added the good first issue Good for newcomers label May 24, 2024
@ivanmurashko
Copy link
Contributor

I am going to take this

ivanmurashko added a commit to ivanmurashko/clangir that referenced this issue May 31, 2024
mlir::cir::ZeroInitConstOp was replaced with llvm.mlir.zero

resolves [llvm#627](llvm#627)
bcardosolopes pushed a commit that referenced this issue Jun 3, 2024
mlir::cir::ZeroInitConstOp was replaced with llvm.mlir.zero

resolves [#627](#627)
pysuxing pushed a commit to pysuxing/llvm-project that referenced this issue Jul 17, 2024
mlir::cir::ZeroInitConstOp was replaced with llvm.mlir.zero

resolves [llvm#627](llvm/clangir#627)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants