[CIR][Codegen][Bugfix] ensure proper tmp location for agg exprs #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
approved these changes
Nov 18, 2023
| // CHECK: %0 = cir.alloca !ty_22B22, cir.ptr <!ty_22B22>, ["agg.tmp.ensured"] {alignment = 8 : i64} | ||
| // CHECK: %1 = cir.const(#cir.zero : ![[ClassB]]) : ![[ClassB]] | ||
| // CHECK: cir.store %1, %0 : ![[ClassB]], cir.ptr <![[ClassB]]> | ||
| // CHECK: cir.call @_ZN1BC2Ev(%0) : (!cir.ptr<![[ClassB]]>) -> () |
There was a problem hiding this comment.
This is nice, the allocation becomes scope local, meaning it's easier to optimize out for some future cases :)
lanza
pushed a commit
that referenced
this pull request
Dec 20, 2023
This PR fixes a bug with wrong arguments passed into the call to
`buildAnyExpr`. This function has args with default values, hence the
bug occurred.
All the changes are even with the clang's original codegen.
For the reference, the LLVM IR code for `agg-init.cpp::usev()` function
looks like the following:
```
define dso_local void @_Z3usev() #0 {
entry:
%agg.tmp.ensured = alloca %struct.yep_, align 4
%Status = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 0
store i32 0, ptr %Status, align 4
%HC = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 1
store i32 0, ptr %HC, align 4
ret void
}
```
lanza
pushed a commit
that referenced
this pull request
Jan 29, 2024
This PR fixes a bug with wrong arguments passed into the call to
`buildAnyExpr`. This function has args with default values, hence the
bug occurred.
All the changes are even with the clang's original codegen.
For the reference, the LLVM IR code for `agg-init.cpp::usev()` function
looks like the following:
```
define dso_local void @_Z3usev() #0 {
entry:
%agg.tmp.ensured = alloca %struct.yep_, align 4
%Status = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 0
store i32 0, ptr %Status, align 4
%HC = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 1
store i32 0, ptr %HC, align 4
ret void
}
```
lanza
pushed a commit
that referenced
this pull request
Mar 23, 2024
This PR fixes a bug with wrong arguments passed into the call to
`buildAnyExpr`. This function has args with default values, hence the
bug occurred.
All the changes are even with the clang's original codegen.
For the reference, the LLVM IR code for `agg-init.cpp::usev()` function
looks like the following:
```
define dso_local void @_Z3usev() #0 {
entry:
%agg.tmp.ensured = alloca %struct.yep_, align 4
%Status = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 0
store i32 0, ptr %Status, align 4
%HC = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 1
store i32 0, ptr %HC, align 4
ret void
}
```
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
This PR fixes a bug with wrong arguments passed into the call to
`buildAnyExpr`. This function has args with default values, hence the
bug occurred.
All the changes are even with the clang's original codegen.
For the reference, the LLVM IR code for `agg-init.cpp::usev()` function
looks like the following:
```
define dso_local void @_Z3usev() #0 {
entry:
%agg.tmp.ensured = alloca %struct.yep_, align 4
%Status = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 0
store i32 0, ptr %Status, align 4
%HC = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 1
store i32 0, ptr %HC, align 4
ret void
}
```
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
This PR fixes a bug with wrong arguments passed into the call to
`buildAnyExpr`. This function has args with default values, hence the
bug occurred.
All the changes are even with the clang's original codegen.
For the reference, the LLVM IR code for `agg-init.cpp::usev()` function
looks like the following:
```
define dso_local void @_Z3usev() #0 {
entry:
%agg.tmp.ensured = alloca %struct.yep_, align 4
%Status = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 0
store i32 0, ptr %Status, align 4
%HC = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 1
store i32 0, ptr %HC, align 4
ret void
}
```
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This PR fixes a bug with wrong arguments passed into the call to
`buildAnyExpr`. This function has args with default values, hence the
bug occurred.
All the changes are even with the clang's original codegen.
For the reference, the LLVM IR code for `agg-init.cpp::usev()` function
looks like the following:
```
define dso_local void @_Z3usev() #0 {
entry:
%agg.tmp.ensured = alloca %struct.yep_, align 4
%Status = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 0
store i32 0, ptr %Status, align 4
%HC = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 1
store i32 0, ptr %HC, align 4
ret void
}
```
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This PR fixes a bug with wrong arguments passed into the call to
`buildAnyExpr`. This function has args with default values, hence the
bug occurred.
All the changes are even with the clang's original codegen.
For the reference, the LLVM IR code for `agg-init.cpp::usev()` function
looks like the following:
```
define dso_local void @_Z3usev() #0 {
entry:
%agg.tmp.ensured = alloca %struct.yep_, align 4
%Status = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 0
store i32 0, ptr %Status, align 4
%HC = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 1
store i32 0, ptr %HC, align 4
ret void
}
```
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Apr 29, 2024
This PR fixes a bug with wrong arguments passed into the call to
`buildAnyExpr`. This function has args with default values, hence the
bug occurred.
All the changes are even with the clang's original codegen.
For the reference, the LLVM IR code for `agg-init.cpp::usev()` function
looks like the following:
```
define dso_local void @_Z3usev() #0 {
entry:
%agg.tmp.ensured = alloca %struct.yep_, align 4
%Status = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 0
store i32 0, ptr %Status, align 4
%HC = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 1
store i32 0, ptr %HC, align 4
ret void
}
```
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This PR fixes a bug with wrong arguments passed into the call to
`buildAnyExpr`. This function has args with default values, hence the
bug occurred.
All the changes are even with the clang's original codegen.
For the reference, the LLVM IR code for `agg-init.cpp::usev()` function
looks like the following:
```
define dso_local void @_Z3usev() #0 {
entry:
%agg.tmp.ensured = alloca %struct.yep_, align 4
%Status = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 0
store i32 0, ptr %Status, align 4
%HC = getelementptr inbounds %struct.yep_, ptr %agg.tmp.ensured, i32 0, i32 1
store i32 0, ptr %HC, align 4
ret void
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with wrong arguments passed into the call to
buildAnyExpr. This function has args with default values, hence the bug occurred.All the changes are even with the clang's original codegen.
For the reference, the LLVM IR code for
agg-init.cpp::usev()function looks like the following: