Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][Lowering] fix lowering for a function ptr field in a global struct #353

Merged
merged 1 commit into from
Dec 13, 2023
Merged

[CIR][Lowering] fix lowering for a function ptr field in a global struct #353

merged 1 commit into from
Dec 13, 2023

Conversation

gitoleg
Copy link
Collaborator

@gitoleg gitoleg commented Dec 13, 2023

This PR fixes a global vars lowering with a funciton ptr field. Previously, the next code caused fail in the foo lowering:

static void myfun(int a) {}

static struct {
    void (*func)(int flag);
} const Handlers[] = {
    {myfun}, {myfun}, {myfun}
};

void foo(int i, int flag) {
    Handlers[i].func(flag);
}

bcardosolopes
bcardosolopes approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcardosolopes bcardosolopes merged commit 77a2b4b into llvm:main Dec 13, 2023
4 checks passed
lanza pushed a commit that referenced this pull request Dec 20, 2023
@gitoleg @lanza
[CIR][Lowering] Fix function ptr field lowering in a global struct (#353
3f94995 
)

This PR fixes a global vars lowering with a funciton ptr field.
Previously, the next code caused fail in the `foo` lowering:
```
static void myfun(int a) {}

static struct {
    void (*func)(int flag);
} const Handlers[] = {
    {myfun}, {myfun}, {myfun}
};

void foo(int i, int flag) {
    Handlers[i].func(flag);
}
```
lanza pushed a commit that referenced this pull request Jan 29, 2024
@gitoleg @lanza
[CIR][Lowering] Fix function ptr field lowering in a global struct (#353
a565498 
)

This PR fixes a global vars lowering with a funciton ptr field.
Previously, the next code caused fail in the `foo` lowering:
```
static void myfun(int a) {}

static struct {
    void (*func)(int flag);
} const Handlers[] = {
    {myfun}, {myfun}, {myfun}
};

void foo(int i, int flag) {
    Handlers[i].func(flag);
}
```
lanza pushed a commit that referenced this pull request Mar 23, 2024
@gitoleg @lanza
[CIR][Lowering] Fix function ptr field lowering in a global struct (#353
8b9804e 
)

This PR fixes a global vars lowering with a funciton ptr field.
Previously, the next code caused fail in the `foo` lowering:
```
static void myfun(int a) {}

static struct {
    void (*func)(int flag);
} const Handlers[] = {
    {myfun}, {myfun}, {myfun}
};

void foo(int i, int flag) {
    Handlers[i].func(flag);
}
```
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@gitoleg @lanza
[CIR][Lowering] Fix function ptr field lowering in a global struct (l…
031bf70 
…lvm#353)

This PR fixes a global vars lowering with a funciton ptr field.
Previously, the next code caused fail in the `foo` lowering:
```
static void myfun(int a) {}

static struct {
    void (*func)(int flag);
} const Handlers[] = {
    {myfun}, {myfun}, {myfun}
};

void foo(int i, int flag) {
    Handlers[i].func(flag);
}
```
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@gitoleg @lanza
[CIR][Lowering] Fix function ptr field lowering in a global struct (l…
5ab50bb 
…lvm#353)

This PR fixes a global vars lowering with a funciton ptr field.
Previously, the next code caused fail in the `foo` lowering:
```
static void myfun(int a) {}

static struct {
    void (*func)(int flag);
} const Handlers[] = {
    {myfun}, {myfun}, {myfun}
};

void foo(int i, int flag) {
    Handlers[i].func(flag);
}
```
lanza pushed a commit that referenced this pull request Apr 29, 2024
@gitoleg @lanza
[CIR][Lowering] Fix function ptr field lowering in a global struct (#353
1ce1d43 
)

This PR fixes a global vars lowering with a funciton ptr field.
Previously, the next code caused fail in the `foo` lowering:
```
static void myfun(int a) {}

static struct {
    void (*func)(int flag);
} const Handlers[] = {
    {myfun}, {myfun}, {myfun}
};

void foo(int i, int flag) {
    Handlers[i].func(flag);
}
```
lanza pushed a commit that referenced this pull request Apr 29, 2024
@gitoleg @lanza
[CIR][Lowering] Fix function ptr field lowering in a global struct (#353
8612779 
)

This PR fixes a global vars lowering with a funciton ptr field.
Previously, the next code caused fail in the `foo` lowering:
```
static void myfun(int a) {}

static struct {
    void (*func)(int flag);
} const Handlers[] = {
    {myfun}, {myfun}, {myfun}
};

void foo(int i, int flag) {
    Handlers[i].func(flag);
}
```
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@gitoleg @lanza
[CIR][Lowering] Fix function ptr field lowering in a global struct (l…
f35510e 
…lvm#353)

This PR fixes a global vars lowering with a funciton ptr field.
Previously, the next code caused fail in the `foo` lowering:
```
static void myfun(int a) {}

static struct {
    void (*func)(int flag);
} const Handlers[] = {
    {myfun}, {myfun}, {myfun}
};

void foo(int i, int flag) {
    Handlers[i].func(flag);
}
```
lanza pushed a commit that referenced this pull request Apr 29, 2024
@gitoleg @lanza
[CIR][Lowering] Fix function ptr field lowering in a global struct (#353
dba066d 
)

This PR fixes a global vars lowering with a funciton ptr field.
Previously, the next code caused fail in the `foo` lowering:
```
static void myfun(int a) {}

static struct {
    void (*func)(int flag);
} const Handlers[] = {
    {myfun}, {myfun}, {myfun}
};

void foo(int i, int flag) {
    Handlers[i].func(flag);
}
```
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
@gitoleg @lanza
[CIR][Lowering] Fix function ptr field lowering in a global struct (l…
6136a9f 
…lvm#353)

This PR fixes a global vars lowering with a funciton ptr field.
Previously, the next code caused fail in the `foo` lowering:
```
static void myfun(int a) {}

static struct {
    void (*func)(int flag);
} const Handlers[] = {
    {myfun}, {myfun}, {myfun}
};

void foo(int i, int flag) {
    Handlers[i].func(flag);
}
```
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@gitoleg @lanza
[CIR][Lowering] Fix function ptr field lowering in a global struct (l…
827048e 
…lvm#353)

This PR fixes a global vars lowering with a funciton ptr field.
Previously, the next code caused fail in the `foo` lowering:
```
static void myfun(int a) {}

static struct {
    void (*func)(int flag);
} const Handlers[] = {
    {myfun}, {myfun}, {myfun}
};

void foo(int i, int flag) {
    Handlers[i].func(flag);
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitoleg @bcardosolopes