-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Frontend][OpenMP] Add suggested brackets in array initialization
Fixes -Werror build after 40137ff.
- Loading branch information
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14e6f63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kparzysz, after this change, the two tests you modified in 40137ff are failing on many bots and appear that they need the CHECK lines to be updated accordingly?
For example from https://lab.llvm.org/buildbot/#/builders/139/builds/63958 directive1.td. Prior to your change, the test was passing and the check line was
But after this change, the compiler now emits an extra pair of braces causing the match to fail:
It appears that the two tests directive1.td and directive2.td may need to be updated to account for the extra braces now being generated unless that is incorrect. Can you take a look and update/fix the failing tests?
Many bots are failing due to this issue including but not limited to the following: