Skip to content

Commit

Permalink
Add "REQUIRES: asserts" to test as it requires the compiler to hit an…
Browse files Browse the repository at this point in the history 
… assertion failure to pass and was failing in release builds.
  • Loading branch information
@dyung
dyung committed Nov 26, 2023
1 parent 3651142 commit 1aa1d17
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions llvm/test/CodeGen/AArch64/store-swift-async-context-clobber-live-reg.ll
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4
; RUN: not --crash llc -o - -mtriple=arm64e-apple-macosx -aarch64-min-jump-table-entries=2 %s
; REQUIRES: asserts

target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"

Expand Down

3 comments on commit 1aa1d17

@dwblaikie
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fhahn

This isn't the only test checking for a crash, or requiring assertions - but in general, we shouldn't be able to reach assertions, right? That's the point, any failed assertion represents a bug/we should have code to handle it. It sounds like from the 820b358 patch description maybe this is intentionally demonstrating a bug, so maybe the bug should/bit of description should be in the test case too?

@fhahn
Copy link
Contributor

@fhahn fhahn commented on 1aa1d17 Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwblaikie Yep I should have added a FIXME, it is intentionally demonstrating a bug. Should be fixed by 58dcac3.

@dyung thanks for adding the missing REQUIRES!

@dwblaikie
Copy link
Collaborator

@dwblaikie dwblaikie commented on 1aa1d17 Dec 5, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwblaikie Yep I should have added a FIXME, it is intentionally demonstrating a bug. Should be fixed by 58dcac3.

Awesome!

Please sign in to comment.