Skip to content

Commit

Permalink
[X86] Return Op instead of SDValue() for lowering flags_read/write in…
Browse files Browse the repository at this point in the history
…trinsics

Returning SDValue() means we didn't handle it and the common
code should try to expand it. But its a target intrinsic so
expanding won't do anything and just leave the node alone. But
it will print confusing debug messages.

By returning Op we tell the common code that the node is legal
and shouldn't receive any further processing.
  • Loading branch information
topperc committed Nov 26, 2019
1 parent a71c1e2 commit 1b20908
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion llvm/lib/Target/X86/X86ISelLowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24105,7 +24105,7 @@ static SDValue LowerINTRINSIC_W_CHAIN(SDValue Op, const X86Subtarget &Subtarget,
MFI.setHasCopyImplyingStackAdjustment(true);
// Don't do anything here, we will expand these intrinsics out later
// during FinalizeISel in EmitInstrWithCustomInserter.
return SDValue();
return Op;
}
case Intrinsic::x86_lwpins32:
case Intrinsic::x86_lwpins64:
Expand Down

0 comments on commit 1b20908

Please sign in to comment.