Skip to content

Commit

Permalink
Disable fail-fast for libc++ builders. (#74485)
Browse files Browse the repository at this point in the history
It seems the fail fast just doesn't strike the right balance.
It wastes too many resources, especially if a build is killed because
the machine it was running on got preempted.

Instead, we should simply not run any future jobs if a failure has
occured, while letting the already running jobs finish.
  • Loading branch information
EricWF committed Dec 5, 2023
1 parent aaf3a8d commit 1e3af94
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/libcxx-build-and-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
runs-on: libcxx-runners-8-set
continue-on-error: false
strategy:
fail-fast: true
fail-fast: false
matrix:
config: [
'generic-cxx03',
Expand Down Expand Up @@ -92,7 +92,7 @@ jobs:
needs: [ stage1 ]
continue-on-error: false
strategy:
fail-fast: true
fail-fast: false
matrix:
config: [
'generic-cxx11',
Expand Down

0 comments on commit 1e3af94

Please sign in to comment.