Skip to content

Commit

Permalink
[libc] Fix some warnings (#66366)
Browse files Browse the repository at this point in the history
Some compilers will warn about dangling else and missleading lack of
parentheses.
  • Loading branch information
abrachet committed Sep 14, 2023
1 parent cb479e7 commit 2ad7a06
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions libc/src/__support/CPP/limits.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ namespace cpp {
// Some older gcc distributions don't define these for 32 bit targets.
#ifndef LLONG_MAX
constexpr size_t LLONG_BIT_WIDTH = sizeof(long long) * 8;
constexpr long long LLONG_MAX = ~0LL ^ (1LL << LLONG_BIT_WIDTH - 1);
constexpr long long LLONG_MIN = 1LL << LLONG_BIT_WIDTH - 1;
constexpr long long LLONG_MAX = ~0LL ^ (1LL << (LLONG_BIT_WIDTH - 1));
constexpr long long LLONG_MIN = 1LL << (LLONG_BIT_WIDTH - 1);
constexpr unsigned long long ULLONG_MAX = ~0ULL;
#endif

Expand Down
5 changes: 3 additions & 2 deletions libc/test/src/ctype/isprint_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@

TEST(LlvmLibcIsPrint, DefaultLocale) {
for (int ch = -255; ch < 255; ++ch) {
if (' ' <= ch && ch <= '~') // A-Z, a-z, 0-9, punctuation, space.
if (' ' <= ch && ch <= '~') { // A-Z, a-z, 0-9, punctuation, space.
EXPECT_NE(__llvm_libc::isprint(ch), 0);
else
} else {
EXPECT_EQ(__llvm_libc::isprint(ch), 0);
}
}
}

0 comments on commit 2ad7a06

Please sign in to comment.