-
Notifications
You must be signed in to change notification settings - Fork 11.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
OpaquePtr: Require byval on x86_intrcc parameter 0
Currently the backend special cases x86_intrcc and treats the first parameter as byval. Make the IR require byval for this parameter to remove this special case, and avoid the dependence on the pointee element type. Fixes bug 46672. I'm not sure the IR is enforcing all the calling convention constraints. clang seems to ignore the attribute for empty parameter lists, but the IR tolerates it.
- Loading branch information
Showing
16 changed files
with
82 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
; RUN: llvm-as < %s | llvm-dis | FileCheck %s | ||
; RUN: verify-uselistorder %s | ||
|
||
; Make sure no arguments is accepted | ||
; CHECK: define x86_intrcc void @no_args() { | ||
define x86_intrcc void @no_args() { | ||
ret void | ||
} | ||
|
||
; CHECK: define x86_intrcc void @byval_arg(i32* byval(i32) %0) { | ||
define x86_intrcc void @byval_arg(i32* byval(i32)) { | ||
ret void | ||
} |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
RUN: llvm-dis %p/Inputs/x86_intrcc_upgrade.bc -o - | FileCheck %s | ||
|
||
Make sure we upgrade x86_intrcc to a byval with explicit type | ||
|
||
CHECK: define x86_intrcc void @no_args() { | ||
CHECK: define x86_intrcc void @non_byval_ptr_arg0(i32* byval(i32) %0) | ||
CHECK: define x86_intrcc void @non_byval_ptr_struct(%struct* byval(%struct) %0) | ||
|
||
CHECK: declare x86_intrcc void @no_args_decl() | ||
CHECK: declare x86_intrcc void @non_byval_ptr_arg0_decl(i32* byval(i32)) | ||
CHECK: declare x86_intrcc void @non_byval_ptr_struct_decl(%struct* byval(%struct)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
; RUN: not llvm-as < %s 2>&1 | FileCheck %s | ||
|
||
; CHECK: Calling convention parameter requires byval | ||
; CHECK-NEXT: void (i32)* @non_ptr_arg0 | ||
define x86_intrcc void @non_ptr_arg0(i32) { | ||
ret void | ||
} | ||
|
||
; CHECK: Calling convention parameter requires byval | ||
; CHECK-NEXT: void (i32*)* @non_byval_ptr_arg0 | ||
define x86_intrcc void @non_byval_ptr_arg0(i32*) { | ||
ret void | ||
} | ||
|
||
; CHECK: Calling convention parameter requires byval | ||
; CHECK-NEXT: void (i32)* @non_ptr_arg0_decl | ||
declare x86_intrcc void @non_ptr_arg0_decl(i32) | ||
|
||
; CHECK: Calling convention parameter requires byval | ||
; CHECK-NEXT: void (i32*)* @non_byval_ptr_arg0_decl | ||
declare x86_intrcc void @non_byval_ptr_arg0_decl(i32*) |