[flang] review comment

Original-commit: flang-compiler/f18@f5c4629 Reviewed-on: flang-compiler/f18#580
llvm · Jul 16, 2019 · 2f49dde · 2f49dde
1 parent 40fb469
commit 2f49dde
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/flang/lib/semantics/resolve-names.cc b/flang/lib/semantics/resolve-names.cc
@@ -3941,7 +3941,7 @@ void DeclarationVisitor::CheckExplicitInterface(Symbol &symbol) {
     const Symbol *subp{FindSubprogram(*interface)};
     if (subp == nullptr || !subp->HasExplicitInterface()) {
       Say(symbol.name(),
-          "The interface of '%s' (%s) is not an abstract interface or a "
+          "The interface of '%s' ('%s') is not an abstract interface or a "
           "procedure with an explicit interface"_err_en_US,
           symbol.name(), interface->name());
       context().SetError(symbol);

diff --git a/flang/test/semantics/resolve20.f90 b/flang/test/semantics/resolve20.f90
@@ -22,20 +22,20 @@ subroutine foo
   procedure(integer) :: b
   procedure(foo) :: c
   procedure(bar) :: d
-  !ERROR: The interface of 'e' (missing) is not an abstract interface or a procedure with an explicit interface
+  !ERROR: The interface of 'e' ('missing') is not an abstract interface or a procedure with an explicit interface
   procedure(missing) :: e
-  !ERROR: The interface of 'f' (b) is not an abstract interface or a procedure with an explicit interface
+  !ERROR: The interface of 'f' ('b') is not an abstract interface or a procedure with an explicit interface
   procedure(b) :: f
   procedure(c) :: g
   external :: h
-  !ERROR: The interface of 'i' (h) is not an abstract interface or a procedure with an explicit interface
+  !ERROR: The interface of 'i' ('h') is not an abstract interface or a procedure with an explicit interface
   procedure(h) :: i
   procedure(forward) :: j
-  !ERROR: The interface of 'k1' (bad1) is not an abstract interface or a procedure with an explicit interface
+  !ERROR: The interface of 'k1' ('bad1') is not an abstract interface or a procedure with an explicit interface
   procedure(bad1) :: k1
-  !ERROR: The interface of 'k2' (bad2) is not an abstract interface or a procedure with an explicit interface
+  !ERROR: The interface of 'k2' ('bad2') is not an abstract interface or a procedure with an explicit interface
   procedure(bad2) :: k2
-  !ERROR: The interface of 'k3' (bad3) is not an abstract interface or a procedure with an explicit interface
+  !ERROR: The interface of 'k3' ('bad3') is not an abstract interface or a procedure with an explicit interface
   procedure(bad3) :: k3
 
   abstract interface

diff --git a/flang/test/semantics/resolve32.f90 b/flang/test/semantics/resolve32.f90
@@ -57,7 +57,7 @@ subroutine foo
     procedure(foo), nopass, deferred :: f
     !ERROR: DEFERRED is required when an interface-name is provided
     procedure(foo), nopass :: g
-    !ERROR: The interface of 'h' (bar) is not an abstract interface or a procedure with an explicit interface
+    !ERROR: The interface of 'h' ('bar') is not an abstract interface or a procedure with an explicit interface
     procedure(bar), nopass, deferred :: h
   end type
   type t2