Skip to content

Commit

Permalink
Add rpath to liblldb so vendors can ship their own python framework (…
Browse files Browse the repository at this point in the history
…or others)

Summary:
I want to be able to specify which python framework to use for lldb in macos. With python2.7 we could just rely on the MacOS one but python3.7 is not shipped with the OS.
An alternative is to use the one shipped with Xcode but that could be path dependent or maybe the user doesn't have Xcode installed at all.
A definite solution is to just ship a python framework with lldb. To make this possible I added "@loader_path/../../../" to the rpath so it points to the same directory as the LLDB.framework, this way we can just drop any frameworks there.

Reviewers: hhb, sgraenitz, xiaobai, smeenai, beanz, labath

Reviewed By: labath

Subscribers: beanz, labath, mgorny, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D69931
  • Loading branch information
aadsm committed Nov 12, 2019
1 parent 4187cb1 commit 31ea714
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions lldb/cmake/modules/LLDBFramework.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -120,3 +120,8 @@ if(NOT IOS)
COMMENT "LLDB.framework: copy clang vendor-specific headers"
)
endif()

# Add an rpath pointing to the directory where LLDB.framework is installed.
# This allows frameworks (relying on @rpath) to be installed in the same folder and found at runtime.
set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH
"@loader_path/../../../")

0 comments on commit 31ea714

Please sign in to comment.