llvm-dwarfdump: Pretty printing types including a space between const…

… and parenthesized references/pointers to arrays
llvm · Sep 19, 2021 · 372e2c2 · 372e2c2
1 parent 391fa37
commit 372e2c2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/llvm/lib/DebugInfo/DWARF/DWARFDie.cpp b/llvm/lib/DebugInfo/DWARF/DWARFDie.cpp
@@ -187,10 +187,10 @@ struct DWARFTypePrinter {
 
   void appendPointerLikeTypeBefore(DWARFDie D, DWARFDie Inner, StringRef Ptr) {
     appendUnqualifiedNameBefore(Inner);
+    if (Word)
+      OS << ' ';
     if (needsParens(Inner))
       OS << '(';
-    else if (Word)
-      OS << ' ';
     OS << Ptr;
     Word = false;
   }

diff --git a/llvm/test/tools/llvm-dwarfdump/X86/prettyprint_types.s b/llvm/test/tools/llvm-dwarfdump/X86/prettyprint_types.s
@@ -60,7 +60,7 @@
 # const reference to a pointer to member function (with const, volatile, rvalue ref qualifiers)
 # CHECK:   DW_AT_type{{.*}}"void (foo::*const &)() const volatile &&")
 
-# CHECK:   DW_AT_type{{.*}}"int *const(&)[1]")
+# CHECK:   DW_AT_type{{.*}}"int *const (&)[1]")
 # CHECK:   DW_AT_type{{.*}}"int *const[1]")
 # CHECK:   DW_AT_type{{.*}}"const int (&)[1]")
 # CHECK:   DW_AT_type{{.*}}"const int [1]")