-
Notifications
You must be signed in to change notification settings - Fork 11.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[libc++] Fix undefined behavior in
std::filebuf
Fixes #49267. Fixes #49282. Fixes #49789. Reviewed By: ldionne Differential Revision: https://reviews.llvm.org/D122257
- Loading branch information
1 parent
1ba8f4f
commit 4ff70db
Showing
3 changed files
with
126 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
...xx/test/std/input.output/file.streams/fstreams/filebuf.assign/nonmember_swap_min.pass.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
// This tests that swapping filebufs works correctly even when the small buffer | ||
// optimization is in use (https://github.com/llvm/llvm-project/issues/49282). | ||
|
||
// <fstream> | ||
|
||
// template <class charT, class traits = char_traits<charT> > | ||
// class basic_filebuf | ||
|
||
// template <class charT, class traits> | ||
// void | ||
// swap(basic_filebuf<charT, traits>& x, basic_filebuf<charT, traits>& y); | ||
|
||
#include <fstream> | ||
#include <cassert> | ||
#include "test_macros.h" | ||
#include "platform_support.h" | ||
|
||
int main(int, char**) | ||
{ | ||
std::string tmpA = get_temp_file_name(); | ||
std::string tmpB = get_temp_file_name(); | ||
|
||
{ | ||
std::ofstream sa(tmpA), sb(tmpB); | ||
sa << "AAAA"; | ||
sb << "BBBB"; | ||
} | ||
|
||
std::filebuf f1; | ||
assert(f1.open(tmpA, std::ios_base::in) != 0); | ||
assert(f1.is_open()); | ||
f1.pubsetbuf(0, 0); | ||
|
||
std::filebuf f2; | ||
assert(f2.open(tmpB, std::ios_base::in) != 0); | ||
assert(f2.is_open()); | ||
f2.pubsetbuf(0, 0); | ||
|
||
assert(f1.sgetc() == 'A'); | ||
assert(f2.sgetc() == 'B'); | ||
|
||
swap(f1, f2); | ||
|
||
assert(f1.is_open()); | ||
assert(f2.is_open()); | ||
|
||
assert(f1.sgetc() == 'B'); | ||
assert(f2.sgetc() == 'A'); | ||
|
||
std::remove(tmpA.c_str()); | ||
std::remove(tmpB.c_str()); | ||
|
||
return 0; | ||
} |