-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[llvm][TableGen][Jupyter] Record current python when kernel is installed
Previously the kernel.json would always point to `python3` even if you installed using a python from a virtualenv. This meant that tools like VSCode would try to run the kernel against the system python and fail. Added a note to the readme about it. I've removed the need to add to PYTHONPTHON as well, turns out it wasn't needed. This fixes an issue reported in https://discourse.llvm.org/t/tablegen-the-playground-ipynb-file-is-not-working-as-expected/71745. Reviewed By: awarzynski Differential Revision: https://reviews.llvm.org/D154351
- Loading branch information
1 parent
b9808e5
commit 535693f
Showing
3 changed files
with
31 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 0 additions & 14 deletions
14
llvm/utils/TableGen/jupyter/tablegen_kernel/assets/kernel.json
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters