-
Notifications
You must be signed in to change notification settings - Fork 11.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland [clang][AIX] add option mdefault-visibility-export-mapping
The option mdefault-visibility-export-mapping is created to allow mapping default visibility to an explicit shared library export (e.g. dllexport). Exactly how and if this is manifested is target dependent (since it depends on how they map dllexport in the IR). Three values are provided for the option: * none: the default and behavior without the option, no additional export linkage information is created. * explicit: add the export for entities with explict default visibility from the source, including RTTI * all: add the export for all entities with default visibility This option is useful for targets which do not export symbols as part of their usual default linkage behaviour (e.g. AIX), such targets traditionally specified such information in external files (e.g. export lists), but this mapping allows them to use the visibility information typically used for this purpose on other (e.g. ELF) platforms. This relands commit: 8c8a267 with fixes for the compile time and assert problems that were reported by: * making shouldMapVisibilityToDLLExport inline and provide an early return in the case where no mapping is in effect (aka non-AIX platforms) * don't try to export RTTI types which we will give internal linkage to Reviewed By: MaskRay Differential Revision: https://reviews.llvm.org/D126340
- Loading branch information
Showing
13 changed files
with
870 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
// RUN: %clang_cc1 -triple powerpc-ibm-aix %s -S -emit-llvm -o - | \ | ||
// RUN: FileCheck -check-prefixes=UNSPECIFIED-DEF,EXPLICIT-DEF %s | ||
// RUN: %clang_cc1 -triple powerpc-ibm-aix %s -mdefault-visibility-export-mapping=none -S -emit-llvm -o - | \ | ||
// RUN: FileCheck -check-prefixes=UNSPECIFIED-DEF,EXPLICIT-DEF %s | ||
// RUN: %clang_cc1 -triple powerpc-ibm-aix %s -mdefault-visibility-export-mapping=explicit -S -emit-llvm -o - | \ | ||
// RUN: FileCheck -check-prefixes=UNSPECIFIED-DEF,EXPLICIT-EXP %s | ||
// RUN: %clang_cc1 -triple powerpc-ibm-aix %s -mdefault-visibility-export-mapping=all -S -emit-llvm -o - | \ | ||
// RUN: FileCheck -check-prefixes=UNSPECIFIED-EXP,EXPLICIT-EXP %s | ||
// RUN: %clang -target powerpc-ibm-aix %s -mdefault-visibility-export-mapping=all -fvisibility=hidden -S -emit-llvm -o - | \ | ||
// RUN: FileCheck -check-prefixes=UNSPECIFIED-HID,EXPLICIT-EXP %s | ||
|
||
// RUN: not %clang -mdefault-visibility-export-mapping=explicit -target powerpc-unknown-linux %s 2>&1 | \ | ||
// RUN: FileCheck -check-prefix=ERROR %s | ||
// ERROR: unsupported option '-mdefault-visibility-export-mapping=explicit' for target 'powerpc-unknown-linux' | ||
|
||
// UNSPECIFIED-DEF: define void @func() | ||
// UNSPECIFIED-HID: define hidden void @func() | ||
// UNSPECIFIED-EXP: define dllexport void @func() | ||
void func() {} | ||
|
||
#pragma GCC visibility push(default) | ||
// EXPLICIT-DEF: define void @pragmafunc() | ||
// EXPLICIT-EXP: define dllexport void @pragmafunc() | ||
void pragmafunc() {} | ||
#pragma GCC visibility pop | ||
|
||
// EXPLICIT-DEF: define void @explicitfunc() | ||
// EXPLICIT-EXP: define dllexport void @explicitfunc() | ||
void __attribute__((visibility("default"))) explicitfunc() {} |
41 changes: 41 additions & 0 deletions
41
clang/test/CodeGenCXX/mdefault-visibility-export-mapping-alias.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
// RUN: %clang_cc1 -triple powerpc-ibm-aix %s -mdefault-visibility-export-mapping=none -mconstructor-aliases -S -emit-llvm -o - | \ | ||
// RUN: FileCheck -check-prefixes=UNSPECIFIED-DEF,EXPLICIT-DEF %s | ||
// RUN: %clang_cc1 -triple powerpc-ibm-aix %s -mdefault-visibility-export-mapping=explicit -mconstructor-aliases -S -emit-llvm -o - | \ | ||
// RUN: FileCheck -check-prefixes=UNSPECIFIED-DEF,EXPLICIT-EXP %s | ||
// RUN: %clang_cc1 -triple powerpc-ibm-aix %s -mdefault-visibility-export-mapping=all -mconstructor-aliases -S -emit-llvm -o - | \ | ||
// RUN: FileCheck -check-prefixes=UNSPECIFIED-EXP,EXPLICIT-EXP %s | ||
|
||
class A { | ||
public: | ||
~A(); | ||
}; | ||
|
||
A::~A() {} | ||
|
||
class __attribute__((visibility("default"))) B { | ||
public: | ||
~B(); | ||
}; | ||
|
||
B::~B() {} | ||
|
||
void func() { | ||
A x; | ||
B y; | ||
} | ||
|
||
// A::~A() (complete object destructor) | ||
// UNSPECIFIED-DEF: @_ZN1AD1Ev = unnamed_addr alias | ||
// UNSPECIFIED-EXP: @_ZN1AD1Ev = dllexport unnamed_addr alias | ||
|
||
// B::~B() (complete object destructor) | ||
// EXPLICIT-DEF: @_ZN1BD1Ev = unnamed_addr alias | ||
// EXPLICIT-EXP: @_ZN1BD1Ev = dllexport unnamed_addr alias | ||
|
||
// A::~A() (base object destructor) | ||
// UNSPECIFIED-DEF: define void @_ZN1AD2Ev( | ||
// UNSPECIFIED-EXP: define dllexport void @_ZN1AD2Ev( | ||
|
||
// B::~B() (base object destructor) | ||
// EXPLICIT-DEF: define void @_ZN1BD2Ev( | ||
// EXPLICIT-EXP: define dllexport void @_ZN1BD2Ev( |
Oops, something went wrong.