-
Notifications
You must be signed in to change notification settings - Fork 11.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SVE] Fix invalid assert in expand_DestructiveOp.
AArch64ExpandPseudo::expand_DestructiveOp contains an assert to ensure the destructive operand's register is unique. However, this is only required when psuedo expansion emits a movprfx. A simple example when a movprfx is not required is Z0 = FADD_ZPZZ_UNDEF_S P0, Z0, Z0 which expands to an unprefixed FADD_ZPmZ_S instruction. This patch moves the assert to the places where a movprfx is emitted. Differential Revision: https://reviews.llvm.org/D83029
- Loading branch information
1 parent
15a60fe
commit 7356b42
Showing
2 changed files
with
28 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve -run-pass=aarch64-expand-pseudo -simplify-mir -verify-machineinstrs %s -o - | FileCheck %s | ||
--- | ||
name: add_x | ||
alignment: 4 | ||
tracksRegLiveness: true | ||
liveins: | ||
- { reg: '$p0' } | ||
- { reg: '$z0' } | ||
frameInfo: | ||
maxCallFrameSize: 0 | ||
body: | | ||
bb.0: | ||
liveins: $p0, $z0 | ||
; CHECK: add_x | ||
; CHECK-NOT: MOVPRFX | ||
; CHECK: $z0 = FADD_ZPmZ_S renamable $p0, killed $z0, renamable $z0 | ||
; CHECK-NEXT: RET | ||
renamable $z0 = FADD_ZPZZ_UNDEF_S renamable $p0, renamable $z0, killed renamable $z0 | ||
RET_ReallyLR | ||
... |