Skip to content

Commit

Permalink
NFC: Migrate LoopUnrollPass to work on InstructionCost
Browse files Browse the repository at this point in the history
This patch migrates cost values and arithmetic to work on InstructionCost.
When the interfaces to TargetTransformInfo are changed, any InstructionCost
state will propagate naturally.

See this patch for the introduction of the type: https://reviews.llvm.org/D91174
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2020-November/146408.html

Reviewed By: david-arm, fhahn

Differential Revision: https://reviews.llvm.org/D95817
  • Loading branch information
sdesmalen-arm committed Feb 4, 2021
1 parent 0fb4341 commit 75b2555
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -361,14 +361,14 @@ static Optional<EstimatedUnrollCost> analyzeLoopUnrollCost(

// The estimated cost of the unrolled form of the loop. We try to estimate
// this by simplifying as much as we can while computing the estimate.
unsigned UnrolledCost = 0;
InstructionCost UnrolledCost = 0;

// We also track the estimated dynamic (that is, actually executed) cost in
// the rolled form. This helps identify cases when the savings from unrolling
// aren't just exposing dead control flows, but actual reduced dynamic
// instructions due to the simplifications which we expect to occur after
// unrolling.
unsigned RolledDynamicCost = 0;
InstructionCost RolledDynamicCost = 0;

// We track the simplification of each instruction in each iteration. We use
// this to recursively merge costs into the unrolled cost on-demand so that
Expand Down Expand Up @@ -639,10 +639,15 @@ static Optional<EstimatedUnrollCost> analyzeLoopUnrollCost(
}
}

assert(UnrolledCost.isValid() && RolledDynamicCost.isValid() &&
"All instructions must have a valid cost, whether the "
"loop is rolled or unrolled.");

LLVM_DEBUG(dbgs() << "Analysis finished:\n"
<< "UnrolledCost: " << UnrolledCost << ", "
<< "RolledDynamicCost: " << RolledDynamicCost << "\n");
return {{UnrolledCost, RolledDynamicCost}};
return {{unsigned(*UnrolledCost.getValue()),
unsigned(*RolledDynamicCost.getValue())}};
}

/// ApproximateLoopSize - Approximate the size of the loop.
Expand Down

0 comments on commit 75b2555

Please sign in to comment.