Skip to content

Commit

Permalink
Remove Go debugger plugin
Browse files Browse the repository at this point in the history
In January Davide sent an e-mail to the mailing list to suggest removing
unmaintained language plugins such as Go and Java. The plan was to have
some cool down period to allow users to speak up, however after that the
plugins were never actually removed.

This patch removes the Go debugger plugin.

The plugin can be added again in the future if it is mature enough both
in terms of testing and maintenance commitment.

Discussion on the mailing list:
http://lists.llvm.org/pipermail/lldb-dev/2018-January/013171.html

Differential revision: https://reviews.llvm.org/D54057

llvm-svn: 346157
  • Loading branch information
JDevlieghere committed Nov 5, 2018
1 parent 115209e commit 77198bc
Show file tree
Hide file tree
Showing 52 changed files with 4 additions and 9,892 deletions.
417 changes: 0 additions & 417 deletions lldb/include/lldb/Symbol/GoASTContext.h

This file was deleted.

1 change: 0 additions & 1 deletion lldb/include/lldb/Symbol/TypeSystem.h
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ class TypeSystem : public PluginInterface {
enum LLVMCastKind {
eKindClang,
eKindSwift,
eKindGo,
eKindJava,
eKindOCaml,
kNumKinds
Expand Down
2 changes: 0 additions & 2 deletions lldb/include/lldb/lldb-forward.h
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ class File;
class FileSpec;
class FileSpecList;
class Flags;
class GoASTContext;
class TypeCategoryImpl;
class FormatManager;
class FormattersMatchCandidate;
Expand Down Expand Up @@ -354,7 +353,6 @@ typedef std::shared_ptr<lldb_private::File> FileSP;
typedef std::shared_ptr<lldb_private::Function> FunctionSP;
typedef std::shared_ptr<lldb_private::FunctionCaller> FunctionCallerSP;
typedef std::shared_ptr<lldb_private::FuncUnwinders> FuncUnwindersSP;
typedef std::unique_ptr<lldb_private::GoASTContext> GoASTContextUP;
typedef std::shared_ptr<lldb_private::InlineFunctionInfo> InlineFunctionInfoSP;
typedef std::shared_ptr<lldb_private::Instruction> InstructionSP;
typedef std::shared_ptr<lldb_private::InstrumentationRuntime>
Expand Down
22 changes: 0 additions & 22 deletions lldb/packages/Python/lldbsuite/test/decorators.py
Original file line number Diff line number Diff line change
Expand Up @@ -600,28 +600,6 @@ def skipUnlessDarwin(func):
return skipUnlessPlatform(lldbplatformutil.getDarwinOSTriples())(func)


def skipUnlessGoInstalled(func):
"""Decorate the item to skip tests when no Go compiler is available."""

def is_go_missing(self):
compiler = self.getGoCompilerVersion()
if not compiler:
return "skipping because go compiler not found"
match_version = re.search(r"(\d+\.\d+(\.\d+)?)", compiler)
if not match_version:
# Couldn't determine version.
return "skipping because go version could not be parsed out of {}".format(
compiler)
else:
min_strict_version = StrictVersion("1.4.0")
compiler_strict_version = StrictVersion(match_version.group(1))
if compiler_strict_version < min_strict_version:
return "skipping because available version ({}) does not meet minimum required version ({})".format(
compiler_strict_version, min_strict_version)
return None
return skipTestIfFn(is_go_missing)(func)


def skipIfHostIncompatibleWithRemote(func):
"""Decorate the item to skip tests if binaries built on this host are incompatible."""

Expand Down

This file was deleted.

21 changes: 0 additions & 21 deletions lldb/packages/Python/lldbsuite/test/lang/go/expressions/main.go

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 77198bc

Please sign in to comment.