Fix crash from use of a temporary after its scope exit

Introduced in D110448 and broke some bots (reported by ASAN). Differential Revision: https://reviews.llvm.org/D110448
llvm · Dec 10, 2021 · 79a0330 · 79a0330
1 parent f829630
commit 79a0330
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/mlir/lib/Conversion/GPUCommon/GPUOpsLowering.cpp b/mlir/lib/Conversion/GPUCommon/GPUOpsLowering.cpp
@@ -238,11 +238,10 @@ LogicalResult GPUPrintfOpToHIPLowering::matchAndRewrite(
   Value zeroI32 = rewriter.create<LLVM::ConstantOp>(
       loc, llvmI32, rewriter.getI32IntegerAttr(0));
 
-  mlir::ValueRange appendFormatArgs = {printfDesc, stringStart, stringLen,
-                                       adaptor.args().empty() ? oneI32
-                                                              : zeroI32};
-  auto appendFormatCall =
-      rewriter.create<LLVM::CallOp>(loc, ocklAppendStringN, appendFormatArgs);
+  auto appendFormatCall = rewriter.create<LLVM::CallOp>(
+      loc, ocklAppendStringN,
+      ValueRange{printfDesc, stringStart, stringLen,
+                 adaptor.args().empty() ? oneI32 : zeroI32});
   printfDesc = appendFormatCall.getResult(0);
 
   // __ockl_printf_append_args takes 7 values per append call