Skip to content

Commit

Permalink
[CodeGen][AArch64] Bail out in performConcatVectorsCombine for scalab…
Browse files Browse the repository at this point in the history
…le vectors

I tried to exercise the existing combine patterns in performConcatVectorsCombine
for scalable vectors and at the moment it doesn't seem possible. Parts of
the code currently assume we're dealing with fixed-width vectors with calls
to getVectorNumElements(), therefore I've decided to simply bail out early
for scalable vectors.

Added a test here to show that we don't crash when attempting to combine
truncate + concat:

  CodeGen/AArch64/concat_vector-truncate-combine.ll

Differential Revision: https://reviews.llvm.org/D114600
  • Loading branch information
david-arm committed Nov 29, 2021
1 parent 90010c2 commit 84364bd
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 0 deletions.
3 changes: 3 additions & 0 deletions llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14109,6 +14109,9 @@ static SDValue performConcatVectorsCombine(SDNode *N,
SDValue N0 = N->getOperand(0), N1 = N->getOperand(1);
unsigned N0Opc = N0->getOpcode(), N1Opc = N1->getOpcode();

if (VT.isScalableVector())
return SDValue();

// Optimize concat_vectors of truncated vectors, where the intermediate
// type is illegal, to avoid said illegality, e.g.,
// (v4i16 (concat_vectors (v2i16 (truncate (v2i64))),
Expand Down
20 changes: 20 additions & 0 deletions llvm/test/CodeGen/AArch64/concat_vector-truncate-combine.ll
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,24 @@ entry:
ret <8 x i16> %shuffle
}


; The concat_vectors operation in this test is introduced when splitting
; the fptrunc operation due to the split <vscale x 4 x double> input operand.
define void @test_concat_fptrunc_v4f64_to_v4f32(<vscale x 4 x float>* %ptr) #1 {
entry:
; CHECK-LABEL: test_concat_fptrunc_v4f64_to_v4f32:
; CHECK: fmov z0.d, #1.00000000
; CHECK-NEXT: ptrue p0.d
; CHECK-NEXT: fcvt z0.s, p0/m, z0.d
; CHECK-NEXT: ptrue p0.s
; CHECK-NEXT: uzp1 z0.s, z0.s, z0.s
; CHECK-NEXT: st1w { z0.s }, p0, [x0]
; CHECK-NEXT: ret
%0 = shufflevector <vscale x 4 x double> insertelement (<vscale x 4 x double> poison, double 1.000000e+00, i32 0), <vscale x 4 x double> poison, <vscale x 4 x i32> zeroinitializer
%1 = fptrunc <vscale x 4 x double> %0 to <vscale x 4 x float>
store <vscale x 4 x float> %1, <vscale x 4 x float>* %ptr, align 4
ret void
}

attributes #0 = { nounwind }
attributes #1 = { "target-features"="+sve" }

0 comments on commit 84364bd

Please sign in to comment.