Skip to content

Commit

Permalink
[llvm-objdump] Fix common symbol output on 32 bit platforms
Browse files Browse the repository at this point in the history
Since https://reviews.llvm.org/D109452 symbol-table.test has
been failing on our Arm32 bots.

https://lab.llvm.org/buildbot/#/builders/171/builds/4201

This is because in that change an implicit widening cast
of the alignment from 32 bit to 64 bit was removed and the
format string expects a 64 bit number.
  • Loading branch information
DavidSpickett committed Oct 4, 2021
1 parent 6bc9a76 commit 8692d07
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion llvm/tools/llvm-objdump/llvm-objdump.cpp
Expand Up @@ -2092,7 +2092,7 @@ void objdump::printSymbol(const ObjectFile *O, const SymbolRef &Symbol,
}

if (Common)
outs() << '\t' << format(Fmt, Symbol.getAlignment());
outs() << '\t' << format(Fmt, static_cast<uint64_t>(Symbol.getAlignment()));
else if (O->isXCOFF())
outs() << '\t'
<< format(Fmt, dyn_cast<const XCOFFObjectFile>(O)->getSymbolSize(
Expand Down

0 comments on commit 8692d07

Please sign in to comment.