[libc++] Removes cpp17_output_iterator's default constructor.

This has been suggested in D117950. Reviewed By: ldionne, #libc, philnik Differential Revision: https://reviews.llvm.org/D118971
llvm · Feb 8, 2022 · a0071b9 · a0071b9
1 parent 3df88ec
commit a0071b9
Show file tree

Hide file tree

Showing 7 changed files with 4,807 additions and 4,830 deletions.
diff --git a/libcxx/test/std/algorithms/alg.modifying.operations/alg.random.sample/sample.pass.cpp b/libcxx/test/std/algorithms/alg.modifying.operations/alg.random.sample/sample.pass.cpp
@@ -66,10 +66,9 @@ void test() {
   const int *oa2 = Expectations::oa2;
   ((void)oa2); // Prevent unused warning
   std::minstd_rand g;
-  SampleIterator end;
-  end = std::sample(PopulationIterator(ia),
-                                  PopulationIterator(ia + is),
-                                  SampleIterator(oa), os, g);
+  SampleIterator end = std::sample(PopulationIterator(ia),
+                                   PopulationIterator(ia + is),
+                                   SampleIterator(oa), os, g);
   assert(static_cast<std::size_t>(end.base() - oa) == std::min(os, is));
   // sample() is deterministic but non-reproducible;
   // its results can vary between implementations.
@@ -123,10 +122,9 @@ void test_small_population() {
   SampleItem oa[os];
   const SampleItem oa1[] = {1, 2, 3, 4, 5};
   std::minstd_rand g;
-  SampleIterator end;
-  end = std::sample(PopulationIterator(ia),
-                                  PopulationIterator(ia + is),
-                                  SampleIterator(oa), os, g);
+  SampleIterator end = std::sample(PopulationIterator(ia),
+                                   PopulationIterator(ia + is),
+                                   SampleIterator(oa), os, g);
   assert(static_cast<std::size_t>(end.base() - oa) == std::min(os, is));
   typedef typename std::iterator_traits<PopulationIterator>::iterator_category PopulationCategory;
   if (std::is_base_of<std::forward_iterator_tag, PopulationCategory>::value) {

diff --git a/...ocale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.pass.cpp b/...ocale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.pass.cpp
diff --git a/....categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp b/....categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
diff --git a/...est/std/localization/locale.categories/category.time/locale.time.put.byname/put1.pass.cpp b/...est/std/localization/locale.categories/category.time/locale.time.put.byname/put1.pass.cpp
@@ -48,7 +48,6 @@ class my_facet
 int main(int, char**)
 {
     char str[200];
-    cpp17_output_iterator<char*> iter;
     tm t;
     t.tm_sec = 6;
     t.tm_min = 3;
@@ -63,15 +62,16 @@ int main(int, char**)
     {
         const my_facet f(LOCALE_en_US_UTF_8, 1);
         std::string pat("Today is %A which is abbreviated %a.");
-        iter = f.put(cpp17_output_iterator<char*>(str), ios, '*', &t, pat.data(), pat.data() + pat.size());
+        cpp17_output_iterator<char*> iter =
+            f.put(cpp17_output_iterator<char*>(str), ios, '*', &t, pat.data(), pat.data() + pat.size());
         std::string ex(str, iter.base());
         assert(ex == "Today is Saturday which is abbreviated Sat.");
     }
     {
         const my_facet f(LOCALE_fr_FR_UTF_8, 1);
         std::string pat("Today is %A which is abbreviated '%a'.");
-        iter = f.put(cpp17_output_iterator<char*>(str), ios, '*', &t,
-                     pat.data(), pat.data() + pat.size());
+        cpp17_output_iterator<char*> iter =
+            f.put(cpp17_output_iterator<char*>(str), ios, '*', &t, pat.data(), pat.data() + pat.size());
         std::string ex(str, iter.base());
         assert((ex == "Today is Samedi which is abbreviated 'Sam'.")||
                (ex == "Today is samedi which is abbreviated 'sam'." )||

diff --git a/...ion/locale.categories/category.time/locale.time.put/locale.time.put.members/put1.pass.cpp b/...ion/locale.categories/category.time/locale.time.put/locale.time.put.members/put1.pass.cpp
@@ -33,7 +33,6 @@ int main(int, char**)
 {
     const my_facet f(1);
     char str[200];
-    cpp17_output_iterator<char*> iter;
     tm t;
     t.tm_sec = 6;
     t.tm_min = 3;
@@ -47,13 +46,15 @@ int main(int, char**)
     std::ios ios(0);
     {
         std::string pat("Today is %A which is abbreviated %a.");
-        iter = f.put(cpp17_output_iterator<char*>(str), ios, '*', &t, pat.data(), pat.data() + pat.size());
+        cpp17_output_iterator<char*> iter =
+            f.put(cpp17_output_iterator<char*>(str), ios, '*', &t, pat.data(), pat.data() + pat.size());
         std::string ex(str, iter.base());
         assert(ex == "Today is Saturday which is abbreviated Sat.");
     }
     {
         std::string pat("The number of the month is %Om.");
-        iter = f.put(cpp17_output_iterator<char*>(str), ios, '*', &t, pat.data(), pat.data() + pat.size());
+        cpp17_output_iterator<char*> iter =
+            f.put(cpp17_output_iterator<char*>(str), ios, '*', &t, pat.data(), pat.data() + pat.size());
         std::string ex(str, iter.base());
         assert(ex == "The number of the month is 05.");
     }