Skip to content

Commit

Permalink
[clang][deps] Fix test by checking ignored files correctly
Browse files Browse the repository at this point in the history
After a rebase, bc1a297 accidentally changed `shouldIgnoreFile(Filename)` to incorrect `IgnoredFiles.count(Filename)`. This avoided using native filenames, which the patch intended to solve in the first place.

Failing Windows builds:
* https://lab.llvm.org/buildbot#builders/123/builds/5147
* https://lab.llvm.org/buildbot#builders/86/builds/17177
  • Loading branch information
jansvoboda11 committed Jul 20, 2021
1 parent 0821c88 commit c94a345
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,7 @@ bool DependencyScanningWorkerFilesystem::shouldIgnoreFile(
llvm::ErrorOr<const CachedFileSystemEntry *>
DependencyScanningWorkerFilesystem::getOrCreateFileSystemEntry(
const StringRef Filename) {
bool ShouldMinimize =
!IgnoredFiles.count(Filename) && shouldMinimize(Filename);
bool ShouldMinimize = !shouldIgnoreFile(Filename) && shouldMinimize(Filename);

if (const auto *Entry = Cache.getCachedEntry(Filename, ShouldMinimize))
return Entry;
Expand Down

0 comments on commit c94a345

Please sign in to comment.