Skip to content

Commit

Permalink
tsan: fix another latent race size bug in test
Browse files Browse the repository at this point in the history
The test contains a race in memset.
The size of reported race depends on how the accessed
memory range split into granules inside of tsan runtime.
The test used to report access of size 8, because presumably
the buffer ended up being aligned to 8 bytes. But after
some unrelated changes this test started to report accesses
of size 1 (presumably .data layout changed), which makes
the test fail.
Guarantee alignment of the buf object explicitly.

Reviewed By: melver

Differential Revision: https://reviews.llvm.org/D107149
  • Loading branch information
dvyukov committed Jul 30, 2021
1 parent 4ab7665 commit ce52e03
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion compiler-rt/test/tsan/Linux/double_race.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// A reproducer for a known issue.
// See reference to double_race.cpp in tsan_rtl_report.cpp for an explanation.

char buf[16];
long long buf[2];
volatile int nreport;

void __sanitizer_report_error_summary(const char *summary) {
Expand Down

0 comments on commit ce52e03

Please sign in to comment.