Skip to content

Commit

Permalink
[lldb-vscode] Fix TestVSCode_module
Browse files Browse the repository at this point in the history
Caused by D86662. The fix is only checking some fields when the expect_debug_info_size flag is true. For some reason this was not failing on a local linux machine.
  • Loading branch information
Walter Erquinigo committed Sep 3, 2020
1 parent 62673c4 commit ddcc7ce
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ def run_test(self, symbol_basename, expect_debug_info_size):
def checkSymbolsLoadedWithSize():
active_modules = self.vscode.get_active_modules()
program_module = active_modules[program_basename]
symbolsStatus = program_module['debugInfoSize']
self.assertIn('symbolFilePath', program_module)
self.assertIn(symbols_path, program_module['symbolFilePath'])
symbol_regex = re.compile(r"[0-9]+(\.[0-9]*)?[KMG]?B")
return symbol_regex.match(program_module['symbolStatus'])

Expand All @@ -48,8 +49,6 @@ def checkSymbolsLoadedWithSize():
program_module = active_modules[program_basename]
self.assertEqual(program_basename, program_module['name'])
self.assertEqual(program, program_module['path'])
self.assertIn('symbolFilePath', program_module)
self.assertIn(symbols_path, program_module['symbolFilePath'])
self.assertIn('addressRange', program_module)

@skipIfWindows
Expand Down

0 comments on commit ddcc7ce

Please sign in to comment.