Skip to content

Commit

Permalink
[MSVC] Silence -Wnon-virtual-dtor on DIA APIs
Browse files Browse the repository at this point in the history
Differential Revision: https://reviews.llvm.org/D116313
  • Loading branch information
aganea committed Jan 3, 2022
1 parent a3ab2c9 commit e32936a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
9 changes: 9 additions & 0 deletions clang/lib/Driver/ToolChains/MSVCSetupApi.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@

#pragma once

#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wnon-virtual-dtor"
#endif

// Constants
//
#ifndef E_NOTFOUND
Expand Down Expand Up @@ -512,3 +517,7 @@ STDMETHODIMP GetSetupConfiguration(_Out_ ISetupConfiguration **ppConfiguration,
#ifdef __cplusplus
}
#endif

#ifdef __clang__
#pragma clang diagnostic pop
#endif
2 changes: 1 addition & 1 deletion llvm/lib/DebugInfo/PDB/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ macro(add_pdb_impl_folder group)
endmacro()

if(LLVM_ENABLE_DIA_SDK)
include_directories(${MSVC_DIA_SDK_DIR}/include)
include_directories(SYSTEM ${MSVC_DIA_SDK_DIR}/include)
set(LIBPDB_LINK_FOLDERS "${MSVC_DIA_SDK_DIR}\\lib")

if ("$ENV{VSCMD_ARG_TGT_ARCH}" STREQUAL "arm64")
Expand Down

0 comments on commit e32936a

Please sign in to comment.