Skip to content

Commit

Permalink
[MLIR][NFC] Improve doc comment and delete stale comment
Browse files Browse the repository at this point in the history
Remove duplicate and stale doc comment on affineParallelize. NFC.
  • Loading branch information
bondhugula committed Jul 16, 2021
1 parent 69a5684 commit edfcfa6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
11 changes: 6 additions & 5 deletions mlir/include/mlir/Dialect/Affine/Utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,12 @@ class Operation;

using ReductionLoopMap = DenseMap<Operation *, SmallVector<LoopReduction, 2>>;

/// Replaces parallel affine.for op with 1-d affine.parallel op.
/// mlir::isLoopParallel detects the parallel affine.for ops.
/// Parallelizes the specified reductions. Parallelization will fail in presence
/// of loop iteration arguments that are not listed in `parallelReductions`.
/// There is no cost model currently used to drive this parallelization.
/// Replaces a parallel affine.for op with a 1-d affine.parallel op. `forOp`'s
/// body is taken by the affine.parallel op and the former is erased.
/// (mlir::isLoopParallel can be used to detect a parallel affine.for op.) The
/// reductions specified in `parallelReductions` are also parallelized.
/// Parallelization will fail in the presence of loop iteration arguments that
/// are not listed in `parallelReductions`.
LogicalResult
affineParallelize(AffineForOp forOp,
ArrayRef<LoopReduction> parallelReductions = {});
Expand Down
4 changes: 0 additions & 4 deletions mlir/lib/Dialect/Affine/Utils/Utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,6 @@ static AffineIfOp hoistAffineIfOp(AffineIfOp ifOp, Operation *hoistOverOp) {
return hoistedIfOp;
}

/// Replace affine.for with a 1-d affine.parallel and clone the former's body
/// into the latter while remapping values. Parallelizes the specified
/// reductions. Parallelization will fail in presence of loop iteration
/// arguments that are not listed in `parallelReductions`.
LogicalResult
mlir::affineParallelize(AffineForOp forOp,
ArrayRef<LoopReduction> parallelReductions) {
Expand Down

0 comments on commit edfcfa6

Please sign in to comment.