-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLANG_ENABLE_OPAQUE_POINTERS=OFF
does not prevent Attempting to get element type of opaque pointer
assertion
#55366
Comments
Do mesa / llvm-spir make use of the driver or the cc1 interface? CLANG_ENABLE_OPAQUE_POINTERS affects whether the driver passes |
I've committed 3d888b0 to clarify the behavior wrt cc1. |
I don't know but for Mesa I worked it around by making Mesa pass On mean term the Mesa code would have to be ported to opaque pointers, but this simple trick made Mesa building again without being too-much intrusive on Mesa code. Note: I've noticed writing |
Based on the linked merge request, mesa is indeed using the cc1 interface.
Right, As far as I can tell, there is nothing actionable here on the LLVM side, apart from the documentation update that has already been committed (see https://llvm.org/docs/OpaquePointers.html#transition-state). |
@illwieckz Opaque pointers are currently enabled by default in Clang, but not in LLVM. |
Ah you're right! That's good then. |
The documentation says:
But I verified in multiple ways this is not true, building clang with
CLANG_ENABLE_OPAQUE_POINTERS=OFF
does not provide previous behaviour.-no-opaque-pointers
) was facing DefaultingCLANG_ENABLE_OPAQUE_POINTERS_INTERNAL
toON
broke OpenCL #54970 whateverCLANG_ENABLE_OPAQUE_POINTERS
isON
orOFF
,see: mesa/mesa#6342 clover: Assertion `NumContainedTys && "Attempting to get element type of opaque pointer"' failed (comment).
CLANG_ENABLE_OPAQUE_POINTERS
set toON
orOFF
,see: How to deal with opaque pointers in the translator KhronosGroup/SPIRV-LLVM-Translator#1444 (comment)
The text was updated successfully, but these errors were encountered: