You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many of math dialect operations now have folders, but that means the tests in math-polynomial-approx.mlir are broken because they are not testing the numerical approximation of the ops but instead the folders.
The test needs to be rewritten to pass in the constants via function arguments so that the ops don't fold.
The text was updated successfully, but these errors were encountered:
This patch refators the polynomial Approx test. Now we pass the constant as function argument to avoid constant folder.
Link: llvm/llvm-project#57613
Reviewed By: Mogball
Differential Revision: https://reviews.llvm.org/D133562
Many of
math
dialect operations now have folders, but that means the tests in math-polynomial-approx.mlir are broken because they are not testing the numerical approximation of the ops but instead the folders.The test needs to be rewritten to pass in the constants via function arguments so that the ops don't fold.
The text was updated successfully, but these errors were encountered: