Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mlir][math] Polynomial Approx tests are broken #57613

Closed
Mogball opened this issue Sep 7, 2022 · 3 comments
Closed

[mlir][math] Polynomial Approx tests are broken #57613

Mogball opened this issue Sep 7, 2022 · 3 comments
Assignees
@jacquesguan
Labels
mlir test-suite

Comments

@Mogball
Copy link
Contributor

Mogball commented Sep 7, 2022

Many of math dialect operations now have folders, but that means the tests in math-polynomial-approx.mlir are broken because they are not testing the numerical approximation of the ops but instead the folders.

The test needs to be rewritten to pass in the constants via function arguments so that the ops don't fold.
@Mogball Mogball added the mlir label Sep 7, 2022
@llvmbot
Copy link
Collaborator

llvmbot commented Sep 7, 2022

@llvm/issue-subscribers-mlir

@jacquesguan
Copy link
Contributor

Fixed in d67603a.

@Mogball
Copy link
Contributor Author

Mogball commented Sep 13, 2022

Thanks!

veselypeta pushed a commit to veselypeta/cherillvm that referenced this issue May 10, 2024
@veselypeta
[mlir][NFC] Fix polynomial Approx test.
c631232 
This patch refators the polynomial Approx test. Now we pass the constant as function argument to avoid constant folder.

Link: llvm/llvm-project#57613

Reviewed By: Mogball

Differential Revision: https://reviews.llvm.org/D133562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacquesguan jacquesguan

Labels
mlir test-suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@EugeneZelenko @jacquesguan @Mogball @llvmbot