Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm/test/CodeGen/X86/callbr-asm-outputs-indirect-isel-m32.ll failing expensive checks #60827

Open
nickdesaulniers opened this issue Feb 17, 2023 · 4 comments
Open

llvm/test/CodeGen/X86/callbr-asm-outputs-indirect-isel-m32.ll failing expensive checks #60827

nickdesaulniers opened this issue Feb 17, 2023 · 4 comments
Assignees
@nickdesaulniers
Labels
bug Indicates an unexpected problem or unintended behavior llvm:codegen test-suite

Comments

@nickdesaulniers
Copy link
Member

I just added a test case that's failing with enable expensive checks.
llvm/test/CodeGen/X86/callbr-asm-outputs-indirect-isel-m32.ll
https://reviews.llvm.org/D140160

I'm going to disable -verify-machineinstrs for now until I have a more complete fix.

cc @nathanchance @jyknight @eefriedman @bwendling
@nickdesaulniers nickdesaulniers added bug Indicates an unexpected problem or unintended behavior test-suite labels Feb 17, 2023
@nickdesaulniers nickdesaulniers self-assigned this Feb 17, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Feb 17, 2023

@llvm/issue-subscribers-bug

@nickdesaulniers
Copy link
Member Author

Original feature: #53562.

@nickdesaulniers
Copy link
Member Author 

*** Bad machine code: Using an undefined physical register ***
- function:    condition_code
- basic block: %bb.0  (0x46f2df0)
- instruction: %2:gr8 = SETCCr 4, implicit $eflags
- operand 2:   implicit $eflags

*** Bad machine code: Using an undefined physical register ***
- function:    condition_code
- basic block: %bb.2 c (0x46f2ff0)
- instruction: %4:gr8 = SETCCr 4, implicit $eflags
- operand 2:   implicit $eflags
LLVM ERROR: Found 2 machine code errors.

is the issue. I suspect I need to be defining eflags as live in for the =ccz flags.

nickdesaulniers added a commit that referenced this issue Feb 17, 2023
@nickdesaulniers
[llvm][test] enable/disable -verify-machineinstrs where possible for …
39811e2 
…callbr

I introduced new tests in
commit 5cc1016 ("[llvm][SelectionDAGBuilder] codegen callbr.landingpad intrinsic")
https://reviews.llvm.org/D140160
that fails expensive checks. Disable -verify-machineinstrs in those
tests for now. Enable it in other tests for now, since MachineVerifier
isn't on by default for assertion builds.

Link: #60827
@nickdesaulniers
Copy link
Member Author

Pushed
commit 39811e2 ("[llvm][test] enable/disable -verify-machineinstrs where possible for callbr")
for now.

CarlosAlbertoEnciso pushed a commit to SNSystems/llvm-debuginfo-analyzer that referenced this issue Feb 17, 2023
@nickdesaulniers @CarlosAlbertoEnciso
[llvm][test] enable/disable -verify-machineinstrs where possible for …
7f0cb8d 
…callbr

I introduced new tests in
commit 5cc1016a57b3 ("[llvm][SelectionDAGBuilder] codegen callbr.landingpad intrinsic")
https://reviews.llvm.org/D140160
that fails expensive checks. Disable -verify-machineinstrs in those
tests for now. Enable it in other tests for now, since MachineVerifier
isn't on by default for assertion builds.

Link: llvm/llvm-project#60827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickdesaulniers nickdesaulniers

Labels
bug Indicates an unexpected problem or unintended behavior llvm:codegen test-suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nickdesaulniers @EugeneZelenko @llvmbot