[clang-format] auto variable initialized with arrow operator can be seen as trailing return type #61469
Assignees
Labels
Comments
|
@llvm/issue-subscribers-clang-format |
gysit
pushed a commit
to nextsilicon/llvm-project
that referenced
this issue
Apr 27, 2023
The heuristic for determining if an arrow is a trailing return arrow looks for the auto keyword, along with parentheses. This isn't sufficient, since it also triggers on variable declarations with an auto type, and with an arrow operator. This patch makes sure a function declaration is being parsed, instead of any other declaration. Fixes llvm#61469 Reviewed By: HazardyKnusperkeks, owenpan, MyDeveloperDay Differential Revision: https://reviews.llvm.org/D147377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Input code:
auto a = (b)->c;Result from clang-format-17 (
main), with default style ({}):auto a = (b) -> c;The arrow is annotated as a trailing return type arrow due to an imperfect heuristic in
determineTokenType.This also applies to
decltype(auto):This issue isn't encountered without the (redundant) parentheses:
auto a = b->c;Originally discovered in https://reviews.llvm.org/D141811; I planned to make a fix for it there, but it turned out harder than I expected, so I'm adding an issue for it so I don't forget.
The text was updated successfully, but these errors were encountered: