Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb-vscode] Instructions for vscode seems outdated #63655

Closed
nolange opened this issue Jul 3, 2023 · 4 comments · Fixed by #68234
Closed

[lldb-vscode] Instructions for vscode seems outdated #63655

nolange opened this issue Jul 3, 2023 · 4 comments · Fixed by #68234
Assignees

Comments

@nolange
Copy link

nolange commented Jul 3, 2023

The steps in the Readme wont lead to a working extension, there seems to be substantial difference in current vscode versions. Seems to be required to add an entry to extensions.json aswell.

{
    "identifier": {
        "id": "llvm.lldb-vscode"
    },
    "version": "0.1.0",
    "location": {
        "$mid": 1,
        "fsPath": "/home/lano/.vscode-oss/extensions/llvm.lldb-vscode-0.1.0",
        "path": "/home/lano/.vscode-oss/extensions/llvm.lldb-vscode-0.1.0",
        "scheme": "file"
    },
    "relativeLocation": "llvm.lldb-vscode-0.1.0",
    "metadata": {
        "installedTimestamp": 1688396120102
    }
}

I only manages to install the tool by building my own vsix with a simple shell script calling the system installed lldb-vscode tool.

@llvmbot
Copy link
Collaborator

llvmbot commented Jul 3, 2023

@llvm/issue-subscribers-lldb

@michael-jabbour-sonarsource

According to microsoft/vscode#178667, using the command Developer: Install Extension from Location is preferred over creating directories manually inside ~/.vscode/extensions.

This created the "llvm.lldb-vscode" entry in extensions.json for me.

@DavidSpickett
Copy link
Collaborator

I hit this just yesterday. @walter-erquinigo do you know what the canonical way should be? Michael's reference seems authoritative.

When I followed the existing instructions it just didn't show up in the installed extensions, and did wonder if I needed an entry in that main json file too.

@walter-erquinigo
Copy link
Member

@DavidSpickett , Michaels' reference is right. Tbh I haven't installed lldb-vscode manually in at least two years, so I'm not surprised that things have changed. I'll send a PR updating the README.
Thanks!

walter-erquinigo added a commit to walter-erquinigo/llvm-project that referenced this issue Oct 4, 2023
lldb-vscode had installation instructions based on creating a folder inside ~/.vscode/extensions, which no longer works. A different installation mechanism is needed based on a VSCode command. More can be read in the contents of this patch.

Closes llvm#63655
@walter-erquinigo walter-erquinigo self-assigned this Oct 4, 2023
walter-erquinigo added a commit that referenced this issue Oct 11, 2023
lldb-vscode had installation instructions based on creating a folder
inside ~/.vscode/extensions, which no longer works. A different
installation mechanism is needed based on a VSCode command. More can be
read in the contents of this patch.

Closes #63655
adrian-prantl pushed a commit to adrian-prantl/llvm-project that referenced this issue Jan 18, 2024
lldb-vscode had installation instructions based on creating a folder
inside ~/.vscode/extensions, which no longer works. A different
installation mechanism is needed based on a VSCode command. More can be
read in the contents of this patch.

Closes llvm#63655

(cherry picked from commit 098c927)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants