-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Test Check duplicates global check lines. #63746
Labels
llvm-tools
All llvm tools that do not have corresponding tag
Comments
EugeneZelenko
added
llvm-tools
All llvm tools that do not have corresponding tag
and removed
new issue
labels
Jul 7, 2023
This also groups unnamed and named globals, which does not work without -DAG:
results in
which cannot be verified (due to the order). |
jdoerfert
added a commit
that referenced
this issue
Jul 14, 2023
This reverts commit 68f5d1b as it is built on top of https://reviews.llvm.org/D148216 which is broken. See also #63746
jdoerfert
added a commit
that referenced
this issue
Jul 14, 2023
This reverts commit 4488ee2, as it is built on top of https://reviews.llvm.org/D148216 which is broken. See also #63746
jdoerfert
added a commit
that referenced
this issue
Jul 14, 2023
This reverts commit 6d64faf, as it is built on top of https://reviews.llvm.org/D148216 which is broken. See also #63746
jdoerfert
added a commit
that referenced
this issue
Jul 14, 2023
Three tests needed manual adjustment after https://reviews.llvm.org/D148216 got reverted. See #63746.
hnrklssn
added a commit
that referenced
this issue
Nov 13, 2023
Recommits the changes from https://reviews.llvm.org/D148216. Explicitly named globals are now matched literally, instead of emitting a capture group for the name. This resolves #70047. Metadata and annotations, on the other hand, are captured and matched against by default, since their identifiers are not stable. The reasons for revert (#63746) have been fixed: The first issue, that of duplicated checkers, has already been resolved in #70050. This PR resolves the second issue listed in #63746, regarding the order of named and unnamed globals. This is fixed by recording the index of substrings containing global values, and sorting the checks according to that index before emitting them. This results in global value checks being emitted in the order they were seen instead of being grouped separately.
zahiraam
pushed a commit
to zahiraam/llvm-project
that referenced
this issue
Nov 20, 2023
Recommits the changes from https://reviews.llvm.org/D148216. Explicitly named globals are now matched literally, instead of emitting a capture group for the name. This resolves llvm#70047. Metadata and annotations, on the other hand, are captured and matched against by default, since their identifiers are not stable. The reasons for revert (llvm#63746) have been fixed: The first issue, that of duplicated checkers, has already been resolved in llvm#70050. This PR resolves the second issue listed in llvm#63746, regarding the order of named and unnamed globals. This is fixed by recording the index of substrings containing global values, and sorting the checks according to that index before emitting them. This results in global value checks being emitted in the order they were seen instead of being grouped separately.
veselypeta
pushed a commit
to veselypeta/cherillvm
that referenced
this issue
Sep 6, 2024
This reverts commit 68f5d1b as it is built on top of https://reviews.llvm.org/D148216 which is broken. See also llvm/llvm-project#63746
veselypeta
pushed a commit
to veselypeta/cherillvm
that referenced
this issue
Sep 6, 2024
This reverts commit 4488ee2, as it is built on top of https://reviews.llvm.org/D148216 which is broken. See also llvm/llvm-project#63746
veselypeta
pushed a commit
to veselypeta/cherillvm
that referenced
this issue
Sep 6, 2024
This reverts commit 6d64faf, as it is built on top of https://reviews.llvm.org/D148216 which is broken. See also llvm/llvm-project#63746
veselypeta
pushed a commit
to veselypeta/cherillvm
that referenced
this issue
Sep 6, 2024
…heir defs" This reverts commit 8a3fdf7 as it is broken. See llvm/llvm-project#63746. Effectively fixes: llvm/llvm-project#63746
veselypeta
pushed a commit
to veselypeta/cherillvm
that referenced
this issue
Sep 6, 2024
Three tests needed manual adjustment after https://reviews.llvm.org/D148216 got reverted. See llvm/llvm-project#63746.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since https://reviews.llvm.org/D148216 global check lines are not cleared properly:
./llvm/utils/update_test_checks.py --check-globals=all test.ll
./llvm/utils/update_test_checks.py --check-globals=all test.ll
The text was updated successfully, but these errors were encountered: