Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept /branch: and /cherry-pick: commands #64803

Closed
tbaederr opened this issue Aug 18, 2023 · 8 comments · Fixed by #81002
Closed

Accept /branch: and /cherry-pick: commands #64803

tbaederr opened this issue Aug 18, 2023 · 8 comments · Fixed by #81002
Assignees
Labels
good first issue https://github.com/llvm/llvm-project/contribute infrastructure Bugs about LLVM infrastructure

Comments

@tbaederr
Copy link
Contributor

This is implemented in llvm/utils/git/github-automation.py.

People can't write /cherry-pick: foobar, because the colon breaks the script. The same is true for /branch.

@tbaederr tbaederr added infrastructure Bugs about LLVM infrastructure good first issue https://github.com/llvm/llvm-project/contribute labels Aug 18, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Aug 18, 2023

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Assign the issue to you.
  2. Fix the issue locally.
  3. Run the test suite locally.
    3.1) Remember that the subdirectories under test/ create fine-grained testing targets, so you can
    e.g. use make check-clang-ast to only run Clang's AST tests.
  4. Create a git commit
  5. Run git clang-format HEAD~1 to format your changes.
  6. Submit the patch to Phabricator.
    6.1) Detailed instructions can be found here

For more instructions on how to submit a patch to LLVM, see our documentation.

If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue.

@llvm/issue-subscribers-good-first-issue

@llvmbot
Copy link
Collaborator

llvmbot commented Aug 18, 2023

@llvm/issue-subscribers-infrastructure

@llvmbot
Copy link
Collaborator

llvmbot commented Aug 18, 2023

This is implemented in llvm/utils/git/github-automation.py.

People can't write /cherry-pick: foobar, because the colon breaks the script. The same is true for /branch.

Error: Command failed due to missing milestone.

@PranavReddyP16
Copy link

Hey, I'm new to llvm and fairly competent with python. I'd love to take this up. I think I see the issue in the file mentioned. What is the expected behaviour here exactly? Currently, I see that the implemented regex does not support having colons in the command, only lowercase letters and hyphens. Are colons the only thing we are looking to support or is there anything else?

@tbaederr
Copy link
Contributor Author

tbaederr commented Sep 1, 2023

Only colons is fine for now.

@Shanchax
Copy link

Shanchax commented Nov 6, 2023

Hi , is the issue still open. I am fairly new to LLVM, but decently proficent in Python and would like to try to resolve this issue. Can this issue be assigned to me please? Thanks.

@Sh0g0-1758
Copy link
Contributor

Hello, I looked at the issue and I believe I can solve it. Can you please assign me the issue, @tbaederr.

@Sh0g0-1758
Copy link
Contributor

Sh0g0-1758 commented Feb 7, 2024

@tbaederr @tstellar , I have created a PR for this issue. Please review it.

nikic pushed a commit that referenced this issue Mar 5, 2024
Fixes: #64803

Removed unsupported branch command and changed Regex to
accept /cherry-pick: command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue https://github.com/llvm/llvm-project/contribute infrastructure Bugs about LLVM infrastructure
Projects
None yet
5 participants