Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github Automation] Update Execute command #81002

Merged
merged 8 commits into from
Mar 5, 2024
Merged

Conversation

Sh0g0-1758
Copy link
Contributor

@Sh0g0-1758 Sh0g0-1758 commented Feb 7, 2024

Fixes: #64803

PR SUMMARY: Removed unsupported branch command and changed Regex to accept /cherry-pick: command.

@Sh0g0-1758
Copy link
Contributor Author

Taken account of these strings :

"/cherry-pick: Hola mundo"
"/branch: owner/repo/branch"
"/cherry-pick Hola mundo"
"/branch owner/repo/branch"
"/branch : owner/repo/branch"
"/cherry-pick : Hola mundo"

@llvmbot
Copy link
Collaborator

llvmbot commented Feb 7, 2024

Taken account of these strings :

"/cherry-pick: Hola mundo"
"/branch: owner/repo/branch"
"/cherry-pick Hola mundo"
"/branch owner/repo/branch"
"/branch : owner/repo/branch"
"/cherry-pick : Hola mundo"

Error: Command failed due to missing milestone.

Copy link
Collaborator

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! I think it looks good, but I leave it to @tstellar to make the final call.

@Sh0g0-1758
Copy link
Contributor Author

ping

@Sh0g0-1758
Copy link
Contributor Author

Sh0g0-1758 commented Mar 2, 2024

ping @AaronBallman @nikic

@Sh0g0-1758
Copy link
Contributor Author

This is a rather trivial issue. If this is not relevant anymore, I will close the PR and you can mark the issue as resolved. Though I do think that adding regex support for cherry-pick seems prudent.

@tstellar
Copy link
Collaborator

tstellar commented Mar 2, 2024

This is a rather trivial issue. If this is not relevant anymore, I will close the PR and you can mark the issue as resolved. Though I do think that adding regex support for cherry-pick seems prudent.

I think this is fine, but maybe remove the comment about the obsolete /branch command in another patch.

@Sh0g0-1758
Copy link
Contributor Author

Sh0g0-1758 commented Mar 2, 2024

I think we can do that in this PR itself. Removing the branch command and adding regex support for the chery-pick command ?
I can change the PR header and provide appropriate description for landing the changes.

@tstellar
Copy link
Collaborator

tstellar commented Mar 2, 2024

OK, that's fine.

@Sh0g0-1758
Copy link
Contributor Author

Sh0g0-1758 commented Mar 2, 2024

I have made some changes in the comments, and since the command will always be cherry-pick now, removed the if statement also. I don't think this can particularly cause a build fail, might be safe to land this without waiting for CI build workflow. Updated the PR Summary and header as well.

@Sh0g0-1758 Sh0g0-1758 changed the title Changed Regex to accept /branch: and /cherry-pick: commands Removed unsupported branch command and changed Regex to accept /cherry-pick: command Mar 2, 2024
@Sh0g0-1758 Sh0g0-1758 changed the title Removed unsupported branch command and changed Regex to accept /cherry-pick: command [Github Automation] Update Execute command Mar 2, 2024
@Sh0g0-1758
Copy link
Contributor Author

Hm.. Some Flang test is failing. I know that the build process on Windows is a little buggy. I leave the rest to your discretion. @tstellar

@Sh0g0-1758
Copy link
Contributor Author

@tstellar, should I pass an empty commit to retrigger the checks?

Copy link

github-actions bot commented Mar 5, 2024

✅ With the latest revision this PR passed the Python code formatter.

@nikic nikic merged commit 9a894e7 into llvm:main Mar 5, 2024
3 of 4 checks passed
@Sh0g0-1758 Sh0g0-1758 deleted the 64803 branch March 5, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept /branch: and /cherry-pick: commands
5 participants