Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[X86] X86FoldTablesEmitter - add support for AVX512 BroadcastFoldTables #66360

Closed
RKSimon opened this issue Sep 14, 2023 · 4 comments
Closed

[X86] X86FoldTablesEmitter - add support for AVX512 BroadcastFoldTables #66360

RKSimon opened this issue Sep 14, 2023 · 4 comments
Assignees
@KanRobert
Labels
backend:X86

Comments

@RKSimon
Copy link
Collaborator

RKSimon commented Sep 14, 2023

X86InstrFoldTables.cpp still contains the (partial) manually generated fold tables for AVX512 broadcast folds, we should be able to generate these like regular memory folds.

It might be necessary to add support for TB_BCAST_SH fp16 folds as well as an additional task
@llvmbot
Copy link
Collaborator

llvmbot commented Sep 14, 2023

@llvm/issue-subscribers-backend-x86

X86InstrFoldTables.cpp still contains the (partial) manually generated fold tables for AVX512 broadcast folds, we should be able to generate these like regular memory folds.

It might be necessary to add support for TB_BCAST_SH fp16 folds as well as an additional task

@phoebewang
Copy link
Contributor

cc @KanRobert @yubingex007-a11y

@RKSimon RKSimon removed the new issue label Sep 14, 2023
@RKSimon RKSimon mentioned this issue Nov 27, 2023
Draft
@KanRobert
Copy link
Contributor

KanRobert commented Nov 27, 2023 •
edited
Loading

Sorry. It seems my classification rules for mails is so ridiculous that I missed lots of notifications.... I will take a look at it. @KanRobert

@KanRobert KanRobert self-assigned this Nov 27, 2023
@KanRobert KanRobert mentioned this issue Nov 28, 2023
Merged
KanRobert added a commit that referenced this issue Nov 30, 2023
@KanRobert
[X86][tablgen] Auto-gen broadcast tables (#73654)
a4e1aa2 
1. Add TB_BCAST_SH for FP16
2. Auto-gen 4 broadcast tables BroadcastTable[1-4]

issue: #66360
@KanRobert
Copy link
Contributor

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KanRobert KanRobert

Labels
backend:X86
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@RKSimon @phoebewang @KanRobert @llvmbot