Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 987087df9002 to release/18.x #79253

Closed
SixWeining opened this issue Jan 24, 2024 · 15 comments
Closed

Backport 987087df9002 to release/18.x #79253

SixWeining opened this issue Jan 24, 2024 · 15 comments

Comments

@SixWeining
Copy link
Contributor

/cherry-pick baba7e4

This can address buildbot failures:

@SixWeining
Copy link
Contributor Author

Hi @tstellar, I know release/18.x is just created. May I cherry-pick this fix into 18.x?

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 24, 2024

@llvm/issue-subscribers-debuginfo

Author: Lu Weining (SixWeining)

/cherry-pick baba7e4

This can address buildbot failures:

@nikic
Copy link
Contributor

nikic commented Jan 24, 2024

Failed workflow: https://github.com/llvm/llvm-project/actions/runs/7635785866/job/20801796617 I think it's because empty --phab-token eats the next arg.

@SixWeining
Copy link
Contributor Author

Failed workflow: https://github.com/llvm/llvm-project/actions/runs/7635785866/job/20801796617 I think it's because empty --phab-token eats the next arg.

I agree. And thanks for the fix.

nikic added a commit that referenced this issue Jan 24, 2024
Remove the `--phab-token` argument (which currently eats the subsequent
"auto" as the token no longer exists) and related code.

I think this will fix the workflow failure in
#79253 (comment).
@nikic
Copy link
Contributor

nikic commented Jan 24, 2024

/cherry-pick baba7e4

@nikic
Copy link
Contributor

nikic commented Jan 24, 2024

Now it fails with (https://github.com/llvm/llvm-project/actions/runs/7638782349/job/20810392396):

cherry-picking ['baba7e4175b6ca21e83b1cf8229f29dbba02e979']
Pushing to https://***@github.com/llvmbot/llvm-project issue79253
Traceback (most recent call last):
  File "/home/runner/work/llvm-project/llvm-project/./llvm/utils/git/github-automation.py", line 679, in <module>
    parser.add_argument(
  File "/home/runner/work/llvm-project/llvm-project/./llvm/utils/git/github-automation.py", line 578, in execute_command
    https://docs.github.com/en/get-started/quickstart/github-glossary#compare-branch
  File "/home/runner/work/llvm-project/llvm-project/./llvm/utils/git/github-automation.py", line 475, in create_branch
    ) -> github.IssueComment.IssueComment:
  File "/home/runner/work/llvm-project/llvm-project/./llvm/utils/git/github-automation.py", line 356, in issue_notify_branch
    based on the text in stdin.
  File "/home/runner/.local/lib/python3.10/site-packages/github/Issue.py", line 343, in create_comment
    headers, data = self._requester.requestJsonAndCheck(
  File "/home/runner/.local/lib/python3.10/site-packages/github/Requester.py", line 442, in requestJsonAndCheck
    return self.__check(
  File "/home/runner/.local/lib/python3.10/site-packages/github/Requester.py", line 487, in __check
    raise self.__createException(status, responseHeaders, data)
github.GithubException.GithubException: 403 {"message": "Resource not accessible by personal access token", "documentation_url": "https://docs.github.com/rest/issues/comments#create-an-issue-comment"}

I think this is because the workflow is defined with permissions: read.

@nikic
Copy link
Contributor

nikic commented Jan 24, 2024

Note that the backport branch did get successfully created at https://github.com/llvmbot/llvm-project/tree/issue79253. It failed when posting the issue comment.

nikic added a commit that referenced this issue Jan 24, 2024
The `/cherry-pick` command needs `issues: write` to post a comment on
the issue. The `/branch` command also posts a comment, and also needs
`pull-requests: write` to open a PR.

This should fix the failure encountered at
#79253 (comment).
@nikic
Copy link
Contributor

nikic commented Jan 24, 2024

/cherry-pick baba7e4

1 similar comment
@nikic
Copy link
Contributor

nikic commented Jan 24, 2024

/cherry-pick baba7e4

Copy link

/branch llvmbot/llvm-project/issue79253

1 similar comment
@nikic
Copy link
Contributor

nikic commented Jan 24, 2024

/branch llvmbot/llvm-project/issue79253

Copy link

Failed to create pull request for issue79253 https://github.com/llvm/llvm-project/actions/runs/7642251632

@nikic
Copy link
Contributor

nikic commented Jan 24, 2024

/branch llvmbot/llvm-project/issue79253

Copy link

/pull-request #79323

@tstellar
Copy link
Collaborator

Merged: c9e73cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants