Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fork handling from release issue workflow #79310

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Jan 24, 2024

This is currently broken, because the check is performed on the wrong repository. repo here is llvm/llvm-project, which is not a fork (so this will always trigger), then we'll push a new branch to llvmbot/llvm-project, and then again set the wrong owner, so we'll look for the branch in llvm/llvm-project rather than llvmbot/llvm-project.

Rather than fixing this, I'm removing the code entirely, as it shouldn't be needed anymore (llvmbot/llvm-project is a fork of llvm/llvm-project).

This will hopefully fix the failure from #79253 (comment).

This is currently broken, because the check is performed on the
wrong repository. repo here is llvm/llvm-project, which is not
a fork (so this will always trigger), then we'll push a new branch
to llvmbot/llvm-project, and then again set the wrong owner, so
we'll look for the branch in llvm/llvm-project.

Rather than fixing this, I'm removing the code entirely, as it
shouldn't be needed anymore (llvmbot/llvm-project is a fork of
llvm/llvm-project).
@nikic nikic requested review from tru and tstellar January 24, 2024 15:44
@nikic nikic merged commit 56444d5 into llvm:main Jan 24, 2024
3 of 4 checks passed
@nikic nikic deleted the fix-release-workflow-fork-handling branch January 24, 2024 16:39
@nikic
Copy link
Contributor Author

nikic commented Jan 24, 2024

The one remaining problem now is that apparently comments posted by the github-actions bot don't trigger new actions, so the /branch comment gets ignored if it's posted by the cherry-pick workflow. Ideally we would just directly create the pull request in the cherry-pick workflow -- I don't think there's a good reason to have the intermediate /branch comment at all.

@nikic
Copy link
Contributor Author

nikic commented Jan 24, 2024

Another issue is that we get duplicate command executions if cherry-pick is part of the issue description and an issue subscriber comment gets posted. We can add <!--IGNORE--> to the start of the subscriber comments to avoid this.

@tstellar
Copy link
Collaborator

The one remaining problem now is that apparently comments posted by the github-actions bot don't trigger new actions, so the /branch comment gets ignored if it's posted by the cherry-pick workflow. Ideally we would just directly create the pull request in the cherry-pick workflow -- I don't think there's a good reason to have the intermediate /branch comment at all.

Right, so the comment needs to be posted using one of the llvmbot tokens we have stored in the secrets.

@nikic
Copy link
Contributor Author

nikic commented Jan 24, 2024

@tstellar That would work as well, but the token currently doesn't have permissions to post comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants