-
Notifications
You must be signed in to change notification settings - Fork 11.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvm-mca hits sanitizer error in cycleEnd #83775
Labels
Comments
@llvm/issue-subscribers-tools-llvm-mca Author: Matt Arsenault (arsenm)
f0484e0 was reverted in 31295bb due to breaking the sanitizer bot.
Reduced testcase:
cycleEnd is erasing a subset of the Instructions vector, but that vector is later read in updateCarriedOver |
I will take a look at this today. |
michaelmaitland
added a commit
to michaelmaitland/llvm-project
that referenced
this issue
Mar 4, 2024
…rectly. llvm#83775 shows llvm-mca hits sanitizer error in cycleEnd. There was an instruction that takes multiple cycles to issue and is finished executing directly after issue. Prior to this patch, the instruction is retired on the first issue cycle, despite taking multiple cycles to issue. To fix this, if an instruction takes multiple cycles to issue and is done executing after issue, let updateCarriedOver retire the instruction when it is fully issued.
michaelmaitland
added a commit
that referenced
this issue
Mar 6, 2024
…rectly (#83881) #83775 shows llvm-mca hits sanitizer error in cycleEnd. There was an instruction that takes multiple cycles to issue and is finished executing directly after issue. Prior to this patch, the instruction is retired on the first issue cycle, despite taking multiple cycles to issue. To fix this, if an instruction takes multiple cycles to issue and is done executing after issue, let updateCarriedOver retire the instruction when it is fully issued.
Fixed by #83881 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
f0484e0 was reverted in 31295bb due to breaking the sanitizer bot.
Reduced testcase:
cycleEnd is erasing a subset of the Instructions vector, but that vector is later read in updateCarriedOver
The text was updated successfully, but these errors were encountered: