New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libc][c11] add support for stdio.h's rename() #84980
Comments
@llvm/issue-subscribers-libc Author: Nick Desaulniers (nickdesaulniers)
See also `7.23.4.2 The rename function` in n3096
|
@llvm/issue-subscribers-c11 Author: Nick Desaulniers (nickdesaulniers)
See also `7.23.4.2 The rename function` in n3096
|
Hi! This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:
If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below. |
@llvm/issue-subscribers-good-first-issue Author: Nick Desaulniers (nickdesaulniers)
See also `7.23.4.2 The rename function` in n3096
libc++ needs this for LIBCXX_ENABLE_FILESYSTEM support. |
Would the implementation be somewhat as in stdio.h's remove() using syscalls? I'll create a PR. |
Hi I am Atharv Kshirsagar from IIT Bombay.I would like to request you to grant me access to the issue.Thanks |
Hi @AtharvKshirsagar , @aniplcc already is working on this (is assigned, and their PR is linked above). Thanks for your interest, but there may be another bug that's a better place to start. |
Adds stdio.h's rename() function as defined in n3096. Fixes #84980.
SYS_rename may be unavailable on architectures such as aarch64 and riscv. rename can be implemented in terms of SYS_rename, SYS_renameat, or SYS_renameat2. I don't have a full picture of the history here, but it seems that SYS_renameat might also be unavailable on some platforms. `man 2 rename` mentions that SYS_renameat2 was added in Linux 3.15. We don't need to support such ancient kernel versions. Link: llvm#84980 Link: llvm#85068
SYS_rename may be unavailable on architectures such as aarch64 and riscv. rename can be implemented in terms of SYS_rename, SYS_renameat, or SYS_renameat2. I don't have a full picture of the history here, but it seems that SYS_renameat might also be unavailable on some platforms. `man 2 rename` mentions that SYS_renameat2 was added in Linux 3.15. We don't need to support such ancient kernel versions prior. Link: #84980 Link: #85068
Adds stdio.h's rename() function as defined in n3096. Fixes llvm#84980.
SYS_rename may be unavailable on architectures such as aarch64 and riscv. rename can be implemented in terms of SYS_rename, SYS_renameat, or SYS_renameat2. I don't have a full picture of the history here, but it seems that SYS_renameat might also be unavailable on some platforms. `man 2 rename` mentions that SYS_renameat2 was added in Linux 3.15. We don't need to support such ancient kernel versions prior. Link: llvm#84980 Link: llvm#85068
See also
7.23.4.2 The rename function
in n3096libc++ needs this for LIBCXX_ENABLE_FILESYSTEM support.
The text was updated successfully, but these errors were encountered: