Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc][stdio][test] fixup rename test #86136

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

nickdesaulniers
Copy link
Member

Link: #84980
Link: #85068

@nickdesaulniers
Copy link
Member Author

cc @aniplcc

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 21, 2024

@llvm/pr-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

Changes

Link: #84980
Link: #85068


Full diff: https://github.com/llvm/llvm-project/pull/86136.diff

2 Files Affected:

  • (modified) libc/test/src/stdio/CMakeLists.txt (+1-1)
  • (modified) libc/test/src/stdio/rename_test.cpp (+2)
diff --git a/libc/test/src/stdio/CMakeLists.txt b/libc/test/src/stdio/CMakeLists.txt
index a11a232c27e1a7..4c38e8aba7d7f2 100644
--- a/libc/test/src/stdio/CMakeLists.txt
+++ b/libc/test/src/stdio/CMakeLists.txt
@@ -354,7 +354,7 @@ if(${LIBC_TARGET_OS} STREQUAL "linux")
       libc.src.unistd.access
       libc.src.unistd.close
   )
-  
+
   add_libc_test(
     rename_test
     SUITE
diff --git a/libc/test/src/stdio/rename_test.cpp b/libc/test/src/stdio/rename_test.cpp
index a9fbe24ded9cf7..3ed39fe8c0eb97 100644
--- a/libc/test/src/stdio/rename_test.cpp
+++ b/libc/test/src/stdio/rename_test.cpp
@@ -6,6 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
+#include "include/llvm-libc-macros/linux/unistd-macros.h"
+#include "include/llvm-libc-macros/linux/sys-stat-macros.h"
 #include "src/errno/libc_errno.h"
 #include "src/fcntl/open.h"
 #include "src/stdio/rename.h"

@nickdesaulniers nickdesaulniers merged commit 0c8dfc8 into llvm:main Mar 21, 2024
4 of 6 checks passed
@nickdesaulniers nickdesaulniers deleted the fix_tests branch March 21, 2024 15:36
Copy link

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 7650a01927b8488b1d6d0930109e78c695193faf daadc72d0d751b4d45b8ae47908dbf523110f3a7 -- libc/test/src/stdio/rename_test.cpp
View the diff from clang-format here.
diff --git a/libc/test/src/stdio/rename_test.cpp b/libc/test/src/stdio/rename_test.cpp
index 3ed39fe8c0..a5dd734c63 100644
--- a/libc/test/src/stdio/rename_test.cpp
+++ b/libc/test/src/stdio/rename_test.cpp
@@ -6,8 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "include/llvm-libc-macros/linux/unistd-macros.h"
 #include "include/llvm-libc-macros/linux/sys-stat-macros.h"
+#include "include/llvm-libc-macros/linux/unistd-macros.h"
 #include "src/errno/libc_errno.h"
 #include "src/fcntl/open.h"
 #include "src/stdio/rename.h"

chencha3 pushed a commit to chencha3/llvm-project that referenced this pull request Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants