token argument should be optional

[pmatos]

It seems like the script llvm/utils/git/code-format-helper.py considers the case where token is None so that the PR is not updated, however it marks the --token argument as required. It seems to be this should be optional.

llvm-project/llvm/utils/git/code-format-helper.py

Line 343 in f7bf11c

"--token", type=str, required=True, help="GitHub authentiation token"

[llvmbot]

@llvm/issue-subscribers-clang-format

Author: Paulo Matos (pmatos)

It seems like the script `llvm/utils/git/code-format-helper.py` considers the case where token is None so that the PR is not updated, however it marks the `--token` argument as required. It seems to be this should be optional.

llvm-project/llvm/utils/git/code-format-helper.py

Line 343 in f7bf11c

"--token", type=str, required=True, help="GitHub authentiation token"

[boomanaiden154]

Do you have a link to a workflow failure that was caused by this flag being required?

[tstellar]

llvm-project/llvm/utils/git/code-format-helper.py

Line 343 in f7bf11c

"--token", type=str, required=True, help="GitHub authentiation token"

I think the reason for this is so the script can be used in a pre-commit git hook on someone's look machine.

[boomanaiden154]

Ah, right. I forgot that was a supported use case.