Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DirectX backend] generate ISG1, OSG1 parts for DXContainer #88778

Closed
1 task
Tracked by #90129
python3kgae opened this issue Apr 15, 2024 · 0 comments · Fixed by #90508
Closed
1 task
Tracked by #90129

[DirectX backend] generate ISG1, OSG1 parts for DXContainer #88778

python3kgae opened this issue Apr 15, 2024 · 0 comments · Fixed by #90508
Assignees
@python3kgae
Labels
backend:DirectX

Comments

@python3kgae
Copy link
Contributor

python3kgae commented Apr 15, 2024 •
edited by damyanp

The struct needs already done by
#57743
#59479
#57744

Just need to build the data in DXContainerGlobals pass.

The document for these parts is tracked with #88775
Deliveries:

  • Generate empty ISG1, OSG1 part in DXContainer for compute shader.
@python3kgae python3kgae self-assigned this Apr 22, 2024
@damyanp damyanp changed the title [DirectX backend] generate ISG1, OSG1, PSV0 part for DXContainer [DirectX backend] generate ISG1, OSG1 parts for DXContainer Apr 23, 2024
@damyanp damyanp mentioned this issue Apr 25, 2024
Open
7 tasks
@python3kgae python3kgae self-assigned this Apr 29, 2024
@python3kgae python3kgae mentioned this issue Apr 29, 2024
Merged
python3kgae added a commit to python3kgae/llvm-project that referenced this issue Apr 29, 2024
@python3kgae
[DirectX backend] generate ISG1, OSG1 part for compute shader
d745a77 
Empty ISG1 and OSG1 parts are generated for compute shader since there's no signature for compute shader.

Fixes llvm#88778
python3kgae added a commit that referenced this issue May 1, 2024
@python3kgae
[DirectX backend] generate ISG1, OSG1 part for compute shader (#90508)
a764f49 
Empty ISG1 and OSG1 parts are generated for compute shader since there's
no signature for compute shader.

Fixes #88778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@python3kgae python3kgae

Labels
backend:DirectX
Projects
HLSL Support
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DirectX backend] generate ISG1, OSG1 part for compute shader python3kgae/llvm-project
1 participant
@python3kgae