[RISCV] Fix SiFive7 formula for Reductions and ordered Reductions #65385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmaitland
changed the title
|
This change is stacked on #65386 |
michaelmaitland
force-pushed
the
sifive7-mca-reductions
branch
from
604eefc
to
9d303c5
Compare
Reductions specified the correct formula in the comments but was implemented incorrectly. Ordered reductions formula was refined to be more accurate to actual hardware. A llvm-mca test case for reductions is added so that we have a better idea of how the model is performing.
michaelmaitland
force-pushed
the
sifive7-mca-reductions
branch
from
9d303c5
to
c0377ce
Compare
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Sep 7, 2023
Local branch amd-gfx ee2d08d Merged main:1438544e2364 into amd-gfx:33cd95d2c4a1 Remote branch main 5b7982f [RISCV] Fix SiFive7 formula for Reductions and ordered Reductions (llvm#65385)
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
…vm#65385) Reductions specified the correct formula in the comments but was implemented incorrectly. Ordered reductions formula was refined to be more accurate to actual hardware. A llvm-mca test case for reductions is added so that we have a better idea of how the model is performing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reductions specified the correct formula in the comments but was
implemented incorrectly.
Ordered reductions formula was refined to be more accurate to actual
hardware.
A llvm-mca test case for reductions is added so that we have a better
idea of how the model is performing.