Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RISCV] Split VFWREDUSUM and VFWREDOSUM SchedWrite #65386

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[RISCV] Split VFWREDUSUM and VFWREDOSUM SchedWrite #65386

merged 1 commit into from
Sep 5, 2023

Conversation

michaelmaitland
Copy link
Contributor

WriteVFWRedOV_From and WriteVFWRedV_From SchedWrite classes exist already, but no pseudos were using the ordered SchedWrite. This change makes it so that the VFWREDOSUM pseudo used the ordered VFW SchedWrite.

@michaelmaitland
[RISCV] Split VFWREDUSUM and VFWREDOSUM pseudos
09e03f7 
WriteVFWRedOV_From and WriteVFWRedV_From SchedWrite classes exist
already, but no pseudos were using the ordered SchedWrite. This change makes it
so that the VFWREDOSUM pseudo used the ordered VFW SchedWrite.
@michaelmaitland michaelmaitland requested a review from a team as a code owner September 5, 2023 17:05
@michaelmaitland michaelmaitland mentioned this pull request Sep 5, 2023
Merged
@michaelmaitland michaelmaitland changed the title [RISCV] Split VFWREDUSUM and VFWREDOSUM pseudos [RISCV] Split VFWREDUSUM and VFWREDOSUM SchedWrite Sep 5, 2023
topperc
topperc approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelmaitland michaelmaitland merged commit e643695 into llvm:main Sep 5, 2023
2 checks passed
@michaelmaitland michaelmaitland deleted the split-reductions branch September 5, 2023 17:39
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
@michaelmaitland @avillega
[RISCV] Split VFWREDUSUM and VFWREDOSUM SchedWrite (llvm#65386)
403d2a4 
WriteVFWRedOV_From and WriteVFWRedV_From SchedWrite classes exist
already, but no pseudos were using the ordered SchedWrite. This change
makes it so that the VFWREDOSUM pseudo used the ordered VFW SchedWrite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topperc topperc topperc approved these changes

@wangpc-pp wangpc-pp Awaiting requested review from wangpc-pp

Assignees
No one assigned
Labels
backend:RISC-V
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelmaitland @topperc